Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-3: Fix EvWrite to release memory correctly #9841

Merged

Conversation

snaury
Copy link
Member

@snaury snaury commented Sep 27, 2024

Changelog entry

...

Changelog category

  • Bugfix

Additional information

Fix EvWrite to release memory correctly. The new EvWrite API was sometimes causing process aborts when attempting to restore a previously released transaction, because release was not actually releasing anything.

Merges #9809.
Fixes #9797.

@snaury snaury self-assigned this Sep 27, 2024
@snaury snaury marked this pull request as ready for review September 27, 2024 08:11
@snaury snaury requested a review from a team as a code owner September 27, 2024 08:11
Copy link

github-actions bot commented Sep 27, 2024

2024-09-27 08:12:18 UTC Pre-commit check for 61dc7ca has started.
2024-09-27 08:14:54 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-27 08:27:51 UTC Build successful.

Copy link

github-actions bot commented Sep 27, 2024

2024-09-27 08:12:47 UTC Pre-commit check for 61dc7ca has started.
2024-09-27 08:15:23 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-27 08:38:25 UTC Build successful.
2024-09-27 08:38:40 UTC Tests are running...
🔴 2024-09-27 10:37:27 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10040 9943 0 13 35 49

🟢 2024-09-27 10:38:10 UTC ydbd size 5.6 GiB changed* by -16 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: f4c79be merge: 61dc7ca diff diff %
ydbd size 5 960 907 320 Bytes 5 960 907 304 Bytes -16 Bytes -0.000%
ydbd stripped size 1 491 824 416 Bytes 1 491 824 416 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 27, 2024

2024-09-27 08:12:57 UTC Pre-commit check for 61dc7ca has started.
2024-09-27 08:15:43 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-27 08:55:05 UTC Build successful.
2024-09-27 08:55:23 UTC Tests are running...
🔴 2024-09-27 10:20:15 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14337 12993 0 4 1299 41

🟢 2024-09-27 10:21:03 UTC ydbd size 8.2 GiB changed* by +192 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: f4c79be merge: 61dc7ca diff diff %
ydbd size 8 802 729 232 Bytes 8 802 729 424 Bytes +192 Bytes +0.000%
ydbd stripped size 480 027 208 Bytes 480 027 208 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury merged commit 89f23d4 into ydb-platform:stable-24-3 Sep 27, 2024
8 of 12 checks passed
@snaury snaury deleted the bugfix-9797-write-release-restore-24-3 branch September 27, 2024 11:28
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants