Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EvWrite to release memory correctly #9809

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

snaury
Copy link
Member

@snaury snaury commented Sep 26, 2024

Changelog entry

...

Changelog category

  • Bugfix

Additional information

Fix EvWrite to release memory correctly. The new EvWrite API was sometimes causing process aborts when attempting to restore a previously released transaction, because release was not actually releasing anything.

Fixes #9797.

@snaury snaury requested a review from azevaykin September 26, 2024 13:37
@snaury snaury marked this pull request as ready for review September 26, 2024 13:38
@snaury snaury self-assigned this Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 13:40:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 61a587d has started.
2024-09-26 13:40:08 UTC Artifacts will be uploaded here
2024-09-26 13:42:59 UTC ya make is running...
🟡 2024-09-26 15:24:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15161 13636 0 11 1401 113

2024-09-26 15:26:02 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-26 15:37:28 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
148 (only retried tests) 54 0 0 0 94

🟢 2024-09-26 15:37:35 UTC Build successful.
🟢 2024-09-26 15:38:16 UTC ydbd size 8.5 GiB changed* by +184 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7cfcc44 merge: 61a587d diff diff %
ydbd size 9 080 256 456 Bytes 9 080 256 640 Bytes +184 Bytes +0.000%
ydbd stripped size 490 858 952 Bytes 490 858 952 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 13:41:17 UTC Pre-commit check linux-x86_64-release-clang14 for 61a587d has started.
2024-09-26 13:41:20 UTC Artifacts will be uploaded here
2024-09-26 13:44:06 UTC ya make is running...
🟢 2024-09-26 14:29:45 UTC Build successful.

Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 13:41:23 UTC Pre-commit check linux-x86_64-release-asan for 61a587d has started.
2024-09-26 13:41:27 UTC Artifacts will be uploaded here
2024-09-26 13:44:20 UTC ya make is running...
🟡 2024-09-26 15:57:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10510 10320 0 37 34 119

🟢 2024-09-26 15:58:13 UTC Build successful.
🟢 2024-09-26 15:58:46 UTC ydbd size 5.7 GiB changed* by -64 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7cfcc44 merge: 61a587d diff diff %
ydbd size 6 084 272 272 Bytes 6 084 272 208 Bytes -64 Bytes -0.000%
ydbd stripped size 1 520 825 392 Bytes 1 520 825 328 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury merged commit 86119d2 into ydb-platform:main Sep 27, 2024
13 checks passed
@snaury snaury deleted the bugfix-9797-write-release-restore branch September 27, 2024 07:34
snaury added a commit to snaury/ydb that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants