Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-3: Pre-serialized bootstrap config #9342

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Sep 17, 2024

Changelog entry

Pre-serialize topic's bootstrap config.

Changelog category

  • Performance improvement

Additional information

...

@CyberROFL CyberROFL linked an issue Sep 17, 2024 that may be closed by this pull request
@CyberROFL CyberROFL changed the title Pre-serialized bootstrap config (#9331) 24-3: Pre-serialized bootstrap config Sep 17, 2024
@CyberROFL CyberROFL marked this pull request as ready for review September 17, 2024 06:46
@CyberROFL CyberROFL requested a review from a team as a code owner September 17, 2024 06:46
Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 06:48:27 UTC Pre-commit check for efc111f has started.
2024-09-17 06:50:56 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-17 07:01:06 UTC Build successful.

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 06:49:07 UTC Pre-commit check for efc111f has started.
2024-09-17 06:51:42 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-17 07:18:29 UTC Build successful.
2024-09-17 07:18:43 UTC Tests are running...
🔴 2024-09-17 09:21:38 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11170 11099 0 16 23 32

🟡 2024-09-17 09:22:24 UTC ydbd size 5.5 GiB changed* by +166.0 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 064fd75 merge: efc111f diff diff %
ydbd size 5 935 736 704 Bytes 5 935 906 736 Bytes +166.0 KiB +0.003%
ydbd stripped size 1 488 073 472 Bytes 1 488 095 616 Bytes +21.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 17, 2024

2024-09-17 06:49:13 UTC Pre-commit check for efc111f has started.
2024-09-17 06:51:49 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-17 07:33:45 UTC Build successful.
2024-09-17 07:34:07 UTC Tests are running...
🔴 2024-09-17 08:59:52 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15474 14142 0 5 1299 28

🟡 2024-09-17 09:00:33 UTC ydbd size 8.2 GiB changed* by +220.9 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 064fd75 merge: efc111f diff diff %
ydbd size 8 762 486 976 Bytes 8 762 713 168 Bytes +220.9 KiB +0.003%
ydbd stripped size 479 058 024 Bytes 479 063 528 Bytes +5.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL enabled auto-merge (squash) September 17, 2024 12:47
@CyberROFL CyberROFL disabled auto-merge September 17, 2024 14:33
@CyberROFL CyberROFL enabled auto-merge (squash) September 17, 2024 14:33
@CyberROFL CyberROFL merged commit 604788d into ydb-platform:stable-24-3 Sep 17, 2024
8 of 12 checks passed
@CyberROFL CyberROFL deleted the preserialized-bootstrap-config-24-3 branch September 17, 2024 16:36
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserialized BootstrapConfig
2 participants