Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-serialized bootstrap config #9331

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Sep 16, 2024

Changelog entry

Pre-serialize topic's bootstrap config.

Changelog category

  • Performance improvement

Additional information

...

@CyberROFL CyberROFL linked an issue Sep 16, 2024 that may be closed by this pull request
@CyberROFL CyberROFL marked this pull request as ready for review September 16, 2024 17:06
@CyberROFL CyberROFL requested a review from a team as a code owner September 16, 2024 17:06
@CyberROFL CyberROFL requested a review from qyryq September 16, 2024 17:06
@CyberROFL CyberROFL requested a review from snaury September 16, 2024 17:08
@CyberROFL CyberROFL enabled auto-merge (squash) September 16, 2024 17:08
@CyberROFL CyberROFL force-pushed the preserialized-bootstrap-config branch from ca5f76e to 21b9a35 Compare September 16, 2024 17:08
Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 17:11:34 UTC Pre-commit check linux-x86_64-release-asan for b54e8a8 has started.
2024-09-16 17:12:17 UTC Artifacts will be uploaded here
2024-09-16 17:15:46 UTC ya make is running...
🔴 2024-09-16 19:05:50 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11644 11435 0 67 45 97

🟢 2024-09-16 19:06:50 UTC Build successful.
🟡 2024-09-16 19:07:26 UTC ydbd size 5.6 GiB changed* by +143.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4dc00f1 merge: b54e8a8 diff diff %
ydbd size 6 045 019 344 Bytes 6 045 166 672 Bytes +143.9 KiB +0.002%
ydbd stripped size 1 512 988 656 Bytes 1 513 005 008 Bytes +16.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 17:12:29 UTC Pre-commit check linux-x86_64-release-clang14 for b54e8a8 has started.
2024-09-16 17:13:16 UTC Artifacts will be uploaded here
2024-09-16 17:16:33 UTC ya make is running...
🟢 2024-09-16 17:39:08 UTC Build successful.

Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 17:14:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for b54e8a8 has started.
2024-09-16 17:14:12 UTC Artifacts will be uploaded here
2024-09-16 17:17:00 UTC ya make is running...
🟡 2024-09-16 18:26:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16296 14587 0 40 1378 291

2024-09-16 18:28:09 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-16 18:38:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
355 (only retried tests) 230 0 32 7 86

2024-09-16 18:39:01 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-09-16 18:47:20 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
134 (only retried tests) 18 0 32 0 84

🟢 2024-09-16 18:47:27 UTC Build successful.
🟡 2024-09-16 18:48:12 UTC ydbd size 8.4 GiB changed* by +148.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 46d60a5 merge: b54e8a8 diff diff %
ydbd size 9 030 033 944 Bytes 9 030 185 824 Bytes +148.3 KiB +0.002%
ydbd stripped size 488 713 864 Bytes 488 722 696 Bytes +8.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 19:55:32 UTC Pre-commit check linux-x86_64-release-asan for 130dada has started.
2024-09-16 19:56:15 UTC Artifacts will be uploaded here
2024-09-16 19:59:37 UTC ya make is running...
🔴 2024-09-16 21:44:54 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11638 11462 0 39 35 102

🟢 2024-09-16 21:45:56 UTC Build successful.
🟡 2024-09-16 21:46:30 UTC ydbd size 5.6 GiB changed* by +173.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c42930c merge: 130dada diff diff %
ydbd size 6 045 032 768 Bytes 6 045 210 352 Bytes +173.4 KiB +0.003%
ydbd stripped size 1 512 992 176 Bytes 1 513 010 416 Bytes +17.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL requested a review from snaury September 16, 2024 19:56
Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 19:56:48 UTC Pre-commit check linux-x86_64-release-clang14 for 130dada has started.
2024-09-16 19:56:57 UTC Artifacts will be uploaded here
2024-09-16 19:59:43 UTC ya make is running...
🟢 2024-09-16 20:07:08 UTC Build successful.

Copy link

github-actions bot commented Sep 16, 2024

2024-09-16 19:57:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 130dada has started.
2024-09-16 19:57:39 UTC Artifacts will be uploaded here
2024-09-16 20:00:38 UTC ya make is running...
🟡 2024-09-16 21:07:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16287 14658 0 1 1600 28

2024-09-16 21:09:24 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-16 21:19:41 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
266 (only retried tests) 174 0 0 8 84

🟢 2024-09-16 21:19:49 UTC Build successful.
🟡 2024-09-16 21:20:27 UTC ydbd size 8.4 GiB changed* by +235.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c42930c merge: 130dada diff diff %
ydbd size 9 030 139 152 Bytes 9 030 380 472 Bytes +235.7 KiB +0.003%
ydbd stripped size 488 721 864 Bytes 488 731 400 Bytes +9.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL merged commit e8c3843 into ydb-platform:main Sep 17, 2024
10 of 12 checks passed
@CyberROFL CyberROFL deleted the preserialized-bootstrap-config branch September 17, 2024 06:43
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Sep 17, 2024
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Sep 17, 2024
@shnikd shnikd mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserialized BootstrapConfig
3 participants