Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kqp): always take snapshot for queries with stream lookup #8267

Merged
merged 2 commits into from
Aug 26, 2024
Merged

fix(kqp): always take snapshot for queries with stream lookup #8267

merged 2 commits into from
Aug 26, 2024

Conversation

ulya-sidorina
Copy link
Collaborator

No description provided.

@ulya-sidorina ulya-sidorina force-pushed the fix/ydb-8206 branch 2 times, most recently from 730917e to 7af3488 Compare August 26, 2024 11:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 11:34:52 UTC Pre-commit check for eeafc58 has started.
⚪ 2024-08-26 11:37:51 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-26 12:53:38 UTC ydbd size 8.2 GiB changed* by +570.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6b0e4a4 merge: eeafc58 diff diff %
ydbd size 8 791 022 600 Bytes 8 791 606 928 Bytes +570.6 KiB +0.007%
ydbd stripped size 479 554 120 Bytes 479 560 712 Bytes +6.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-08-26 12:53:39 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 11:35:03 UTC Pre-commit check for eeafc58 has started.
⚪ 2024-08-26 11:38:06 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-26 11:51:31 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 11:37:11 UTC Pre-commit check for eeafc58 has started.
⚪ 2024-08-26 11:40:47 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-26 12:52:51 UTC Check cancelled

@ulya-sidorina ulya-sidorina linked an issue Aug 26, 2024 that may be closed by this pull request
Stream lookup always needs snapshot (for ISOLATION_LEVEL_SERIALIZABLE) #8206
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 12:56:51 UTC Pre-commit check for 33d5ffd has started.
⚪ 2024-08-26 12:59:36 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-26 13:12:54 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 12:57:21 UTC Pre-commit check for 33d5ffd has started.
⚪ 2024-08-26 13:00:05 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-26 13:05:25 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 13:05:19 UTC Pre-commit check for 33d5ffd has started.
⚪ 2024-08-26 13:09:23 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-26 13:12:20 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 13:17:25 UTC Pre-commit check for 80a9e76 has started.
⚪ 2024-08-26 13:21:20 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-26 15:03:48 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10077 9955 0 50 44 28

🟢 2024-08-26 15:04:42 UTC Build successful.
🟢 2024-08-26 15:05:17 UTC ydbd size 5.5 GiB changed* by -80 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 43019e6 merge: 80a9e76 diff diff %
ydbd size 5 925 799 544 Bytes 5 925 799 464 Bytes -80 Bytes -0.000%
ydbd stripped size 1 488 593 520 Bytes 1 488 593 456 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 13:42:10 UTC Pre-commit check for 80a9e76 has started.
⚪ 2024-08-26 13:46:58 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-26 14:54:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39200 33759 0 67 5357 17

⚪ 2024-08-26 14:57:44 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-26 15:05:23 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
84 (only retried tests) 75 0 0 0 9

🟢 2024-08-26 15:05:30 UTC Build successful.
🟢 2024-08-26 15:06:12 UTC ydbd size 8.2 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 43019e6 merge: 80a9e76 diff diff %
ydbd size 8 795 033 768 Bytes 8 795 033 768 Bytes 0 Bytes 0.000%
ydbd stripped size 479 689 064 Bytes 479 689 064 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚪ 2024-08-26 13:48:07 UTC Pre-commit check for 80a9e76 has started.
⚪ 2024-08-26 13:51:44 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-26 13:57:33 UTC Build successful.

@ulya-sidorina ulya-sidorina marked this pull request as ready for review August 26, 2024 15:18
@ulya-sidorina ulya-sidorina merged commit da98ea2 into ydb-platform:main Aug 26, 2024
10 of 12 checks passed
ulya-sidorina added a commit to ulya-sidorina/ydb that referenced this pull request Aug 26, 2024
@ulya-sidorina
fix(kqp): always take snapshot for queries with stream lookup (ydb-pl…
16bf054 
…atform#8267)
ulya-sidorina added a commit to ulya-sidorina/ydb that referenced this pull request Aug 26, 2024
@ulya-sidorina
fix(kqp): always take snapshot for queries with stream lookup (ydb-pl…
926ba47 
…atform#8267)
ulya-sidorina added a commit to ulya-sidorina/ydb that referenced this pull request Aug 27, 2024
@ulya-sidorina
fix(kqp): always take snapshot for queries with stream lookup (ydb-pl…
379f9fc 
…atform#8267)
This was referenced Aug 27, 2024
Merged
Merged
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Aug 28, 2024
@ulya-sidorina @rekby
fix(kqp): always take snapshot for queries with stream lookup (ydb-pl…
e6ca6ef 
…atform#8267)
ulya-sidorina added a commit to ulya-sidorina/ydb that referenced this pull request Aug 29, 2024
@ulya-sidorina
fix(kqp): always take snapshot for queries with stream lookup (ydb-pl…
2569604 
…atform#8267)
@niksaveliev niksaveliev mentioned this pull request Aug 29, 2024
Merged
This was referenced Aug 30, 2024
Merged
Merged
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
@ulya-sidorina @stanislav-shchetinin
fix(kqp): always take snapshot for queries with stream lookup (ydb-pl…
6a0998b 
…atform#8267)
@siarheivesialou siarheivesialou mentioned this pull request Sep 4, 2024
Merged
ulya-sidorina added a commit that referenced this pull request Sep 5, 2024
@ulya-sidorina
fix(kqp): always take snapshot for queries with stream lookup (#8267) (…
df7e1b2 
…#8327)
@niksaveliev niksaveliev mentioned this pull request Sep 9, 2024
Merged
spuchin pushed a commit to spuchin/ydb that referenced this pull request Sep 9, 2024
@ulya-sidorina @spuchin
fix(kqp): always take snapshot for queries with stream lookup (ydb-pl…
baf5768 
…atform#8267) (ydb-platform#8327)
ssmike pushed a commit to ssmike/ydb that referenced this pull request Sep 9, 2024
@ulya-sidorina @ssmike
fix(kqp): always take snapshot for queries with stream lookup (ydb-pl…
3cb3ba4 
…atform#8267)
@ssmike ssmike mentioned this pull request Sep 9, 2024
Merged
ssmike added a commit that referenced this pull request Sep 11, 2024
@ssmike @ulya-sidorina
fix(kqp): always take snapshot for queries with stream lookup (#8267) (…
1992619 
…#8990)

Co-authored-by: Iuliia Sidorina <yulia@ydb.tech>
@niksaveliev niksaveliev mentioned this pull request Sep 12, 2024
Merged
This was referenced Sep 17, 2024
Merged
Merged
This was referenced Oct 29, 2024
Closed
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spuchin spuchin spuchin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stream lookup always needs snapshot (for ISOLATION_LEVEL_SERIALIZABLE)
2 participants
@ulya-sidorina @spuchin