Skip to content

Commit

Permalink
fix(kqp): always take snapshot for queries with stream lookup
Browse files Browse the repository at this point in the history
  • Loading branch information
ulya-sidorina committed Aug 26, 2024
1 parent af9b3a8 commit 730917e
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions ydb/core/kqp/common/kqp_tx.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,11 @@ bool NeedSnapshot(const TKqpTransactionContext& txCtx, const NYql::TKikimrConfig
return true;
}

// We always need snapshot for stream lookup, besause it's used for dependent reads
if (hasStreamLookup) {
return true;
}

// We don't want snapshot when there are effects at the moment,
// because it hurts performance when there are multiple single-shard
// reads and a single distributed commit. Taking snapshot costs
Expand Down

0 comments on commit 730917e

Please sign in to comment.