Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style tests and add workaround to fix PR check for them #7899

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

maximyurchuk
Copy link
Collaborator

@maximyurchuk maximyurchuk commented Aug 16, 2024

Changelog entry

Style tests were fixed

Also add --retest (see DEVTOOLSSUPPORT-49387) to fix behaviour of style tests + retries

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 10:46:09 UTC Pre-commit check for f6d9884 has started.
2024-08-16 10:49:44 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-16 10:53:05 UTC Build successful.

Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 10:48:46 UTC Pre-commit check for f6d9884 has started.
2024-08-16 10:52:05 UTC Check linux-x86_64-relwithdebinfo is running...
🟢 2024-08-16 11:31:37 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64136 50530 0 0 13601 5

🟢 2024-08-16 11:37:22 UTC Build successful.
🟢 2024-08-16 11:37:41 UTC ydbd size 8.1 GiB changed* by -32 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3094f27 merge: f6d9884 diff diff %
ydbd size 8 733 102 680 Bytes 8 733 102 648 Bytes -32 Bytes -0.000%
ydbd stripped size 475 304 264 Bytes 475 304 264 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 16, 2024

2024-08-16 10:51:00 UTC Pre-commit check for f6d9884 has started.
2024-08-16 10:53:16 UTC Check linux-x86_64-release-asan is running...
🟢 2024-08-16 11:51:51 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2886 2848 0 0 33 5

🟢 2024-08-16 11:52:11 UTC Build successful.
🟢 2024-08-16 11:52:32 UTC ydbd size 5.5 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3094f27 merge: f6d9884 diff diff %
ydbd size 5 878 703 744 Bytes 5 878 703 648 Bytes -96 Bytes -0.000%
ydbd stripped size 1 476 910 864 Bytes 1 476 910 800 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants