Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YQ-3363 fix internal error for insert without params #8074

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Aug 21, 2024

Changelog entry

Fixed internal error for insert without params

Changelog category

  • Bugfix

Additional information

  • Changed error to generic error
  • Fixed segfault in session actor for STATS_COLLECTION_FULL

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner August 21, 2024 04:21
@GrigoriyPA GrigoriyPA requested a review from Hor911 August 21, 2024 04:23
Copy link

github-actions bot commented Aug 21, 2024

2024-08-21 04:24:38 UTC Pre-commit check for 4e3534b has started.
2024-08-21 04:27:20 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-21 05:54:10 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9970 9909 0 16 26 19

🟢 2024-08-21 05:55:03 UTC Build successful.
🟢 2024-08-21 05:55:34 UTC ydbd size 5.5 GiB changed* by +11.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b23ee92 merge: 4e3534b diff diff %
ydbd size 5 887 787 880 Bytes 5 887 799 600 Bytes +11.4 KiB +0.000%
ydbd stripped size 1 478 454 192 Bytes 1 478 458 864 Bytes +4.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 21, 2024

2024-08-21 04:24:41 UTC Pre-commit check for 4e3534b has started.
2024-08-21 04:27:36 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-21 04:33:34 UTC Build successful.

Copy link

github-actions bot commented Aug 21, 2024

2024-08-21 04:25:17 UTC Pre-commit check for 4e3534b has started.
2024-08-21 04:28:05 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-21 05:54:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39044 33701 0 5 5318 20

2024-08-21 05:57:31 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-21 06:05:02 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26 (only retried tests) 18 0 0 0 8

🟢 2024-08-21 06:05:09 UTC Build successful.
🟢 2024-08-21 06:05:46 UTC ydbd size 8.1 GiB changed* by +8.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b23ee92 merge: 4e3534b diff diff %
ydbd size 8 748 412 848 Bytes 8 748 421 160 Bytes +8.1 KiB +0.000%
ydbd stripped size 475 824 616 Bytes 475 825 128 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA force-pushed the YQ-3363-fix-internal-error-for-insert-without-params branch from 6cb0860 to b36c390 Compare August 21, 2024 11:21
Copy link

github-actions bot commented Aug 21, 2024

2024-08-21 11:25:26 UTC Pre-commit check for 6bc9bbc has started.
2024-08-21 11:28:07 UTC Check linux-x86_64-release-asan is running...
2024-08-21 12:11:22 UTC Check cancelled

@GrigoriyPA GrigoriyPA requested a review from dorooleg August 21, 2024 12:09
@GrigoriyPA GrigoriyPA added the rebase-and-check Rebase PR with the current base branch and check label Aug 21, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

2024-08-21 12:14:58 UTC Pre-commit check for 8fac477 has started.
2024-08-21 12:19:06 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-21 12:24:03 UTC Build successful.

Copy link

github-actions bot commented Aug 21, 2024

2024-08-21 12:14:59 UTC Pre-commit check for 8fac477 has started.
2024-08-21 12:18:00 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-21 13:45:13 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9775 9701 0 29 27 18

🟢 2024-08-21 13:46:06 UTC Build successful.
🟢 2024-08-21 13:46:35 UTC ydbd size 5.5 GiB changed* by +7.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e56caba merge: 8fac477 diff diff %
ydbd size 5 887 888 592 Bytes 5 887 896 192 Bytes +7.4 KiB +0.000%
ydbd stripped size 1 478 482 992 Bytes 1 478 483 632 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 21, 2024

2024-08-21 12:15:07 UTC Pre-commit check for 8fac477 has started.
2024-08-21 12:17:51 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-21 13:42:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38695 33351 0 7 5320 17

2024-08-21 13:45:35 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-21 13:54:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27 (only retried tests) 17 0 1 0 9

2024-08-21 13:54:19 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-21 14:02:44 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16 (only retried tests) 7 0 0 0 9

🟢 2024-08-21 14:02:52 UTC Build successful.
🟢 2024-08-21 14:03:27 UTC ydbd size 8.1 GiB changed* by +44.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7f8f368 merge: 8fac477 diff diff %
ydbd size 8 748 593 000 Bytes 8 748 638 712 Bytes +44.6 KiB +0.001%
ydbd stripped size 475 832 936 Bytes 475 833 768 Bytes +832 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit ea5d31f into ydb-platform:main Aug 21, 2024
12 of 17 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-3363-fix-internal-error-for-insert-without-params branch August 21, 2024 14:37
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants