Fix kikimr_runner for ubuntu 20.04 #7895
Conversation
482837e to
5fac69a
Compare
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| "mon={}".format(self.__mon_port), | ||
| "ic={}".format(self.__ic_port), | ||
| ] | ||
| return self.ssh_command("sudo service kikimr start") |
There was a problem hiding this comment.
Если мне не изменяет память на современных убунтах и без этого работало
Плюс не сломал ли ты старые убунты этой правкой?
| ] | ||
| return self.ssh_command("sudo service kikimr start") | ||
|
|
||
| slot_dir = "/Berkanavt/kikimr_{slot}".format(slot=self.__slot_id) |
There was a problem hiding this comment.
Это же копипаста из
def _deploy_slot_config_for_tenant(self, slot, tenant, node):
Можно ли как-то без копипасты? (я если что не уверен до конца)
| self.ssh_command(["sudo", "touch", env_txt]) | ||
| self.ssh_command(["/bin/echo", "-e", "\"{}\"".format(cfg), "|", "sudo", "tee", slot_cfg]) | ||
|
|
||
| return self.ssh_command(["sudo", "systemctl", "start", "kikimr-multi@{}".format(self.__slot_id)]) |
There was a problem hiding this comment.
Тоже слом убунты 14 (systemctl)?
Changelog entry
...
Changelog category
Additional information
This change breaks compatibility with ubuntu 14.04 in order to run correctly on 20.04
...