Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change max size of DP table #1423

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Change max size of DP table #1423

merged 4 commits into from
Jan 30, 2024

Conversation

Dark-Avery
Copy link
Contributor

Changing default max size of DP table for DPccp algorithm
Also change size of bitset for graph

@Dark-Avery Dark-Avery requested a review from a team as a code owner January 30, 2024 14:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 14:35:40 UTC Pre-commit check for 809cc84 has started.
⚪ 2024-01-30 14:35:42 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-01-30 14:42:07 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 14:35:45 UTC Pre-commit check for 809cc84 has started.
⚪ 2024-01-30 14:35:47 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-01-30 14:42:07 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 14:46:54 UTC Pre-commit check for 6cc7b36 has started.
⚪ 2024-01-30 14:46:56 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-30 14:49:11 UTC Build successful.
⚪ 2024-01-30 14:49:20 UTC Tests are running...
🔴 2024-01-30 16:35:19 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60300 50916 0 33 9311 40

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 15:32:14 UTC Pre-commit check for 6cc7b36 has started.
⚪ 2024-01-30 15:32:16 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-30 15:34:24 UTC Build successful.
⚪ 2024-01-30 15:34:36 UTC Tests are running...
🔴 2024-01-30 17:15:48 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16031 15853 0 42 111 25

pavelvelikhov
pavelvelikhov reviewed Jan 30, 2024
View reviewed changes
ydb/library/yql/dq/opt/dq_opt_join_cost_based.cpp Outdated
@@ -718,7 +718,7 @@ template <int N> std::bitset<N> TDPccpSolver<N>::NextBitset(const std::bitset<N>
return res;

// TODO: We can optimize this with a few long integer operations,
// but it will only work for 254 bit bitsets
// but it will only work for 128 bit bitsets
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a commented line, any the method below (which is commented out) works only for 64 bits. Can you change this comment back?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 18:31:00 UTC Pre-commit check for c7d4628 has started.
⚪ 2024-01-30 18:31:01 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-01-30 18:31:40 UTC Check cancelled

@github-actions GitHub Actions
Copy link

⚫ 2024-01-30 18:31:29 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 18:33:33 UTC Pre-commit check for fcf74be has started.
⚪ 2024-01-30 18:33:36 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-30 18:36:24 UTC Build successful.
⚪ 2024-01-30 18:36:38 UTC Tests are running...
🟢 2024-01-30 20:12:32 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60316 50995 0 0 9264 57

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚪ 2024-01-30 18:33:56 UTC Pre-commit check for fcf74be has started.
⚪ 2024-01-30 18:33:58 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-30 18:36:50 UTC Build successful.
⚪ 2024-01-30 18:37:03 UTC Tests are running...
🔴 2024-01-30 20:14:29 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16034 15910 0 23 65 36

resetius
resetius approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@resetius resetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to define this constant somewhere as a constexpr

@pavelvelikhov pavelvelikhov merged commit bd5ea97 into ydb-platform:main Jan 30, 2024
3 of 4 checks passed
@vitstn vitstn mentioned this pull request Jan 31, 2024
Merged
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 31, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 31, 2024
Merged
This was referenced Jan 31, 2024
Closed
Merged
This was referenced Feb 1, 2024
Closed
Draft
This was referenced Feb 1, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@vitstn vitstn mentioned this pull request Feb 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelvelikhov pavelvelikhov pavelvelikhov left review comments

@resetius resetius resetius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dark-Avery @resetius @pavelvelikhov