Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add subcommands in workload-transfer #1462

Merged
merged 8 commits into from
Feb 16, 2024

Conversation

Jornydb
Copy link
Contributor

@Jornydb Jornydb commented Jan 31, 2024

[docs] Add subcommands in workload-transfer

@Jornydb Jornydb requested a review from a team as a code owner January 31, 2024 10:37
@Jornydb Jornydb added the documentation Improvements or additions to documentation label Jan 31, 2024
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@@ -82,7 +82,10 @@
`--message-size`, `-m` | Размер сообщения в байтах. Возможно задание в КБ, МБ, ГБ путем добавления суффиксов `K`, `M`, `G` соответственно | `10240`
`--message-rate` | Целевая суммарная скорость записи. В сообщениях в секунду. Исключает использование параметра `--byte-rate` | `0`
`--byte-rate` | Целевая суммарная скорость записи. В байтах в секунду. Исключает использование параметра --message-rate. Возможно задание в КБ/с, МБ/с, ГБ/с путем добавления суффиксов `K`, `M`, `G` соответственно | `0`
`--commit-period` | Период между вызовами `COMMIT`. В секундах | `10`
`--commit-period` | Период между вызовами `COMMIT`. В секундах | `10`
`--commit-messages` | Период между вызовами `COMMIT`. В количестве сообщений | `1024*1000`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вместо "В количестве сообщений" лучше "Количество сообщений"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вместо "В количестве сообщений" лучше "Количество сообщений"
Значение по умолчанию равно 1000000.

@@ -120,6 +123,7 @@ Window Write speed Write time Inflight Lag Lag time
* `Lag` — максимальное число сообщений, ожидающих чтения, в окне сбора статистики. Учитываются сообщения по всем партициям.
* `Lag time` — процентиль времени задержки сообщений в мс.
* `Read speed` — скорость чтения сообщений читателями. В сообщениях в секунду и в мегабайтах в секунду.
* `Select time`, `Upsert time`, `Commit time` — время выполнения операций Select, Upsert, Commit в мс.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"процентиль времени выполнения...". Как для Lag time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"процентиль времени выполнения...". Как для Lag time

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented Feb 1, 2024

✅ Documentation build

Revision built successfully
Revision preview link

Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
Copy link

github-actions bot commented Feb 1, 2024

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented Feb 1, 2024

✅ Documentation build

Revision built successfully
Revision preview link

@Jornydb Jornydb marked this pull request as draft February 1, 2024 09:07
fomichev3000
fomichev3000 previously approved these changes Feb 4, 2024
`--commit-period` | The period between `COMMIT` calls. In seconds | `10`
`--commit-messages` | The period between `COMMIT` calls. In number of messages | `1000000`
`--only-topic-in-tx` | Only topic partitions are forced to participate in transactions Excludes the use of the `--only-table-in-tx` parameter | `0`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A point symbol is missed befor "Excludes".
"in transactions Excludes"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A point symbol is missed befor "Excludes". "in transactions Excludes"

@@ -112,6 +115,7 @@ Window Write speed Write time Inflight Lag Lag time
* `Lag` — the specified percentile of maximum number of messages waiting to be read in the statistics collection window. Messages for all batches are taken into account.
* `Lag time` — the specified percentile of message delay time in ms.
* `Read speed` — the speed of reading messages by consumers. In messages per second and in megabytes per second.
* `Select time`, `Upsert time`, `Commit time` — the specified percentile of the execution time of Select, Insert, Commit operations in ms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't see this columns in the table above. It may be OK, just noticed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't see this columns in the table above. It may be OK, just noticed.

@Jornydb Jornydb marked this pull request as ready for review February 5, 2024 12:34
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@blinkov blinkov merged commit 75f69cf into ydb-platform:main Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants