Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation for incorrect blob writing #12758

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Improvement

Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 07:59:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 60607fd has started.
2024-12-19 08:00:24 UTC Artifacts will be uploaded here
2024-12-19 08:03:49 UTC ya make is running...
2024-12-19 08:18:12 UTC Check cancelled

Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 07:59:53 UTC Pre-commit check linux-x86_64-release-asan for 60607fd has started.
2024-12-19 08:00:38 UTC Artifacts will be uploaded here
2024-12-19 08:04:29 UTC ya make is running...
2024-12-19 08:17:55 UTC Check cancelled

Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 08:21:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for fa17aa2 has started.
2024-12-19 08:22:03 UTC Artifacts will be uploaded here
2024-12-19 08:25:16 UTC ya make is running...
🟡 2024-12-19 09:45:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30747 27787 0 7 2835 118

2024-12-19 09:48:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-19 10:00:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 65 0 1 0 110

2024-12-19 10:00:30 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-19 10:12:13 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
156 (only retried tests) 46 0 1 0 109

🟢 2024-12-19 10:12:20 UTC Build successful.
🟢 2024-12-19 10:12:43 UTC ydbd size 2.1 GiB changed* by +73.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3ea526b merge: fa17aa2 diff diff %
ydbd size 2 254 802 928 Bytes 2 254 878 280 Bytes +73.6 KiB +0.003%
ydbd stripped size 483 250 224 Bytes 483 259 696 Bytes +9.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 08:21:59 UTC Pre-commit check linux-x86_64-release-asan for fa17aa2 has started.
2024-12-19 08:22:03 UTC Artifacts will be uploaded here
2024-12-19 08:25:13 UTC ya make is running...
🟡 2024-12-19 09:47:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13819 13686 0 61 22 50

🟢 2024-12-19 09:49:11 UTC Build successful.
🟡 2024-12-19 09:49:35 UTC ydbd size 3.6 GiB changed* by +116.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 3ea526b merge: fa17aa2 diff diff %
ydbd size 3 896 410 736 Bytes 3 896 530 368 Bytes +116.8 KiB +0.003%
ydbd stripped size 1 364 406 448 Bytes 1 364 421 360 Bytes +14.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Dec 19, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 15:58:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for b046566 has started.
2024-12-19 15:58:21 UTC Artifacts will be uploaded here
2024-12-19 16:01:33 UTC ya make is running...
🟡 2024-12-19 17:22:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30754 27797 0 5 2834 118

2024-12-19 17:26:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-19 17:39:35 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
174 (only retried tests) 64 0 0 0 110

🟢 2024-12-19 17:39:42 UTC Build successful.
🟢 2024-12-19 17:40:01 UTC ydbd size 2.1 GiB changed* by +73.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 62bfab3 merge: b046566 diff diff %
ydbd size 2 234 602 320 Bytes 2 234 677 672 Bytes +73.6 KiB +0.003%
ydbd stripped size 477 805 488 Bytes 477 814 960 Bytes +9.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 15:58:21 UTC Pre-commit check linux-x86_64-release-asan for b046566 has started.
2024-12-19 15:58:32 UTC Artifacts will be uploaded here
2024-12-19 16:01:28 UTC ya make is running...
🟡 2024-12-19 17:22:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13822 13750 0 22 5 45

🟢 2024-12-19 17:24:18 UTC Build successful.
🟡 2024-12-19 17:24:42 UTC ydbd size 3.6 GiB changed* by +182.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4b88656 merge: b046566 diff diff %
ydbd size 3 865 228 040 Bytes 3 865 414 992 Bytes +182.6 KiB +0.005%
ydbd stripped size 1 350 329 808 Bytes 1 350 372 624 Bytes +41.8 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review December 19, 2024 19:06
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner December 19, 2024 19:06
@ivanmorozov333 ivanmorozov333 merged commit 737b0d5 into ydb-platform:main Dec 19, 2024
13 of 14 checks passed
@ivanmorozov333 ivanmorozov333 deleted the add_validation_blob_size branch December 19, 2024 19:06
asmyasnikov pushed a commit to asmyasnikov/ydb that referenced this pull request Dec 23, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants