Skip to content

Commit

Permalink
Revert "Enabled by default enable_antlr4_parser feature-flag for ydb … (
Browse files Browse the repository at this point in the history
  • Loading branch information
asmyasnikov authored Dec 19, 2024
1 parent 892a954 commit 3ea526b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ydb/tests/fq/s3/test_ydb_over_fq.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ def test_execute_data_query_error(self, kikimr, s3, client, unique_prefix, yq_ve
with session.transaction() as tx:
assert_that(
calling(tx.execute).with_args("BAD QUERY"),
raises(ydb.issues.InternalError, "(mismatched input .* expecting)|(Unexpected token .* : cannot match to any predicted input)"),
raises(ydb.issues.InternalError, "Unexpected token .* : cannot match to any predicted input"),
)
with session.transaction() as tx:
query = "select * from {}{}".format("bindings." if yq_version == "v1" else "", "WRONG_BIND")
Expand Down
2 changes: 1 addition & 1 deletion ydb/tests/fq/yds/test_select_1.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def test_compile_error(self, client, yq_version):
assert (
"Query failed with code " + ("ABORTED" if yq_version == "v1" else "GENERIC_ERROR") in describe_string
), describe_string
assert "extraneous input" in describe_string or "Unexpected token" in describe_string, describe_string
assert "Unexpected token" in describe_string, describe_string
# Failed to parse query is added in YQv1 only
if yq_version == "v1":
assert "Failed to parse query" in describe_string, describe_string
Expand Down
1 change: 0 additions & 1 deletion ydb/tests/library/harness/resources/default_yaml.yml
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ feature_flags:
enable_persistent_query_stats: true
enable_scheme_transactions_at_scheme_shard: true
enable_mvcc_snapshot_reads: true
enable_antlr4_parser: true
kqpconfig:
settings:
- name: "_ResultRowsLimit"
Expand Down

0 comments on commit 3ea526b

Please sign in to comment.