Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid changing shardstate reads list during iteration #12150

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

ssmike
Copy link
Collaborator

@ssmike ssmike commented Nov 29, 2024

Changelog entry

Changelog category

  • Bugfix

Copy link

github-actions bot commented Nov 29, 2024

2024-11-29 15:50:10 UTC Pre-commit check linux-x86_64-release-asan for 0104f73 has started.
2024-11-29 15:50:21 UTC Artifacts will be uploaded here
2024-11-29 15:53:18 UTC ya make is running...
🟡 2024-11-29 16:55:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13231 13170 0 11 5 45

🟢 2024-11-29 16:56:30 UTC Build successful.
🟢 2024-11-29 16:56:58 UTC ydbd size 4.9 GiB changed* by +3.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8edc4ee merge: 0104f73 diff diff %
ydbd size 5 281 682 168 Bytes 5 281 685 944 Bytes +3.7 KiB +0.000%
ydbd stripped size 1 361 444 816 Bytes 1 361 445 456 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 29, 2024

2024-11-29 15:51:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0104f73 has started.
2024-11-29 15:51:35 UTC Artifacts will be uploaded here
2024-11-29 15:54:30 UTC ya make is running...
🟡 2024-11-29 16:42:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20916 19406 0 1 1396 113

2024-11-29 16:44:05 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-29 16:55:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
740 (only retried tests) 634 0 0 0 106

🟢 2024-11-29 16:55:51 UTC Build successful.
🟢 2024-11-29 16:56:10 UTC ydbd size 2.5 GiB changed* by +3.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8edc4ee merge: 0104f73 diff diff %
ydbd size 2 687 135 784 Bytes 2 687 138 888 Bytes +3.0 KiB +0.000%
ydbd stripped size 482 300 496 Bytes 482 301 072 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

robot-magpie bot commented Nov 29, 2024

@ulya-sidorina has triggered the import of a pull request, but it hasn't started. If you are a Yandex employee, you can view the log.

@ssmike ssmike merged commit a4e7da0 into ydb-platform:main Nov 29, 2024
11 checks passed
@ssmike ssmike deleted the fix-reads-iteration branch November 29, 2024 19:04
gridnevvvit pushed a commit to gridnevvvit/ydb that referenced this pull request Dec 1, 2024
gridnevvvit pushed a commit to gridnevvvit/ydb that referenced this pull request Dec 1, 2024
ssmike added a commit to ssmike/ydb that referenced this pull request Dec 2, 2024
gridnevvvit added a commit that referenced this pull request Dec 2, 2024
gridnevvvit added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants