avoid changing shardstate reads list during iteration (#12150)

ydb-platform · Nov 29, 2024 · a4e7da0 · a4e7da0
1 parent 1b51ba9
commit a4e7da0
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/ydb/core/kqp/runtime/kqp_stream_lookup_actor.cpp b/ydb/core/kqp/runtime/kqp_stream_lookup_actor.cpp
@@ -413,12 +413,16 @@ class TKqpStreamLookupActor : public NActors::TActorBootstrapped<TKqpStreamLooku
         auto shardIt = ReadsPerShard.find(tabletId);
         YQL_ENSURE(shardIt != ReadsPerShard.end());
 
+        TVector<TReadState*> toRetry;
         for (auto* read : shardIt->second.Reads) {
             if (read->State == EReadState::Running) {
                 Counters->IteratorDeliveryProblems->Inc();
-                RetryTableRead(*read);
+                toRetry.push_back(read);
             }
         }
+        for (auto* read : toRetry) {
+            RetryTableRead(*read);
+        }
     }
 
     void Handle(TEvPrivate::TEvSchemeCacheRequestTimeout::TPtr&) {