Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: emoji should default to true on darwin platforms #3766

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Fix: emoji should default to true on darwin platforms #3766

merged 1 commit into from
Jun 30, 2017

Conversation

BYK
Copy link
Member

@BYK BYK commented Jun 29, 2017 •
edited
Loading

Summary

Fixes #3764. Follow up to #3126. Adds the missing [bool] type
descriptor to commander definitions.

Test plan

Run yarn on macOS and enjoy your emojis responsibly.

Fix: emoji should default to true on darwin platforms
91e7729 
**Summary**

Fixes #3764. Follow up to #3126. Adds the missing `[bool]` type
descripter to `commander` definitions.

**Test plan**

Run `yarn` on macOS and enjoy your emojis responsibly.
@BYK BYK requested review from arcanis and bestander June 29, 2017 23:04
@bestander bestander merged commit 69574f6 into master Jun 30, 2017
bestander added a commit that referenced this pull request Jun 30, 2017
@bestander
Revert "Fix: emoji should default to true on darwin platforms (#3766)"
e3117cb 
This reverts commit 69574f6.
bestander added a commit that referenced this pull request Jun 30, 2017
@bestander
Revert "Update: add regression tests for Git.spawn env issues" (#3768)
de7bef4 
* Revert "Fix: emoji should default to true on darwin platforms (#3766)"

This reverts commit 69574f6.

* Revert "Support for ~ (home dir) in path configurations (#3756)"

This reverts commit 35ee7de.

* Revert "Update: add regression tests for Git.spawn env issues (#3759)"

This reverts commit cd26fec.
@cpojer cpojer deleted the emoji branch July 7, 2017 13:21
@elyobo
Copy link
Contributor

elyobo commented Jul 12, 2017

Oops, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bestander bestander bestander approved these changes

@arcanis arcanis Awaiting requested review from arcanis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BYK @elyobo @bestander