Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💩💩💩💩 EMOJI STOPPED WORKING 💩💩💩💩 #3764

Closed
bestander opened this issue Jun 29, 2017 · 1 comment
Closed

💩💩💩💩 EMOJI STOPPED WORKING 💩💩💩💩 #3764

bestander opened this issue Jun 29, 2017 · 1 comment
Assignees
@BYK
Labels
high-priority triaged

Comments

@bestander
Copy link
Member

caused by #3126

screen shot 2017-06-29 at 3 26 57 pm
@BYK BYK self-assigned this Jun 29, 2017
BYK pushed a commit that referenced this issue Jun 29, 2017
Fix: emoji should default to true on darwin platforms
91e7729 
**Summary**

Fixes #3764. Follow up to #3126. Adds the missing `[bool]` type
descripter to `commander` definitions.

**Test plan**

Run `yarn` on macOS and enjoy your emojis responsibly.
@BYK BYK mentioned this issue Jun 29, 2017
Merged
bestander pushed a commit that referenced this issue Jun 30, 2017
@BYK @bestander
Fix: emoji should default to true on darwin platforms (#3766)
69574f6 
**Summary**

Fixes #3764. Follow up to #3126. Adds the missing `[bool]` type
descripter to `commander` definitions.

**Test plan**

Run `yarn` on macOS and enjoy your emojis responsibly.
@elyobo
Copy link
Contributor

elyobo commented Jul 12, 2017

Sorry, was after emojis for all, not blocking them for darwin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BYK BYK

Labels
high-priority triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BYK @elyobo @bestander