IYY-303: Callout component animations and background image options #467
+236
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to use `npm run develop`, the watched files in webpack would remove the fonts folder from dist on update, causing issues when we try to verify links and the like. This ensures that it keeps them there on cleanups.
…ase if cta-group is present;
The new way to deal with default values is to use an args attribute, but our old way was to include this in the argTypes. This produces a valid args hash from the argTypes.
The date logic was quite complex. We refactored this so that we could easily add more date formats and reference them with an override if we needed a specific one. An example of this was for the post "By author | DATE", which was formatted outside of this twig. Now we can include an override for items like this to force a certain style, while allowing the existing functionality to remain.
This reverts commit e23d60f.
It looks as if the meta components use a format of day__full, which is not defined in the comments.
IYY-296 - Fix Views spacing
fix(webpack): watched webpack keeps fonts
The previous Figma URL was out of date, so this points now to the latest UI Kit version. Since we also are not using Percy, I removed that as well, and we can re-add it if we decide to re-activate it in the CI.
Update Git PR Template Figma URL and remove Percy reference
…l-align IYY-302: Add vertical text alignment to Spotlights
YSP-762: Post Date Refactor
This should be done better such that the user does not have to create JSON.
We have "reference_card__image" instead
When screen size is very small, mimic when it's desktop sized where the image is on top of the content.
dblanken-yale
approved these changes
Feb 7, 2025
codechefmarc
approved these changes
Feb 7, 2025
…ry-styling YSP-768: Update category styling on reference cards
…-styling YSP-564: Custom Cards on mobile responsiveness
While the default placeholder is nice, we want to be able to track link contrast issues in the footer. This allows us to provide an override on the Storybook side that would allow us to display this for verification, while keeping existing functionality.
We want to see actual links inside of the footer, so this is a way for us to do so to verify contrast issues.
This allows us to see what links would really look like in the component library.
This reverts commit b68004a.
To make sure we pass contrast, we are forcing this to mimic the color of the text it is with.
To pass contrast, mimic the content portion to have a consistent footer that passes contrast tests.
…er-link-contrast YSP-785: A11y: New Haven Green + ONHA Mega Footer link contrast
|
Can this target the |
|
@dblanken-yale Updated all three repos to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IYY-303: Callout component animations and background image options
Description of work
Testing Link(s)
Functional Review Steps
With Animationiyy-tile-item-animation.mp4
With Animationiyy-tiles-animation.mp4
Design Review
yds-text-linkaround thecontentinstead of providing a button as in the designs. We could add a button option, but it would exist with the option to link thecontentas is currently in place. It might be odd having two link options per tile, but let me know if you'd like to discuss this further.Accessibility Review