YSP-785: A11y: New Haven Green + ONHA Mega Footer link contrast #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-component-library-twig ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3 tasks
ntay90
approved these changes
Jan 30, 2025
While the default placeholder is nice, we want to be able to track link contrast issues in the footer. This allows us to provide an override on the Storybook side that would allow us to display this for verification, while keeping existing functionality.
We want to see actual links inside of the footer, so this is a way for us to do so to verify contrast issues.
This allows us to see what links would really look like in the component library.
This reverts commit b68004a.
To make sure we pass contrast, we are forcing this to mimic the color of the text it is with.
To pass contrast, mimic the content portion to have a consistent footer that passes contrast tests.
988480d to
81c43f9
Compare
Merged
|
🎉 This PR is included in version 1.49.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YSP-785: A11y: New Haven Green + ONHA Mega Footer link contrast
Description of work
Testing Link(s)
Functional Review Steps
Controls, changeFooter Variation (dial)tomegaFooter Theme (dial)fromonetotwoandthreeand verify the same is trueSite: Global Theme (lever)to a new theme and verify it all againTheme settingsto play with the footer settings thereDesign Review
Accessibility Review