Fix for incorrect marking EOL if connection fails #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the bug that incorrectly assumes EOL if connection fails. See xolox#1
xolox
added a commit
that referenced
this pull request
Nov 1, 2017
xolox
added a commit
that referenced
this pull request
Nov 1, 2017
This change set builds on top of edcf561 to enhance validate_mirror() by making a distinction between a confirmed HTTP 404 response versus other error conditions which may be of a more transient nature. The goal of this change is to preserve the semantics requested in issue #1 and implemented in pull request #2 without needing the additional HTTP request performed by can_connect_to_mirror(). Because validate_mirror() previously returned a boolean but now returns an enumeration member this change is technically backwards incompatible, then again validate_mirror() isn't specifically intended for callers because it concerns internal logic of apt-mirror-updater. When I publish this I will nevertheless bump the major version number.
xolox
added a commit
that referenced
this pull request
Nov 1, 2017
Recently I ran into the issue that the logic to check whether a release is EOL (that works by checking if the security mirror serves a Release.gpg file for the release) failed on me. More specifically the following URL still exists at the time of writing (2017-11-01) even though Ubuntu 12.04 went EOL back in April: http://security.ubuntu.com/ubuntu/dists/precise/Release.gpg At the same time issue #1 and pull request #2 were also indications that the EOL detection was fragile and error prone. This potential fragility had bugged me ever since publishing apt-mirror-updater and this week I finally finished a more robust and deterministic EOL detection scheme.
xolox
added a commit
that referenced
this pull request
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug that incorrectly assumes EOL if connection fails.
See #1