Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow passing of additional arguments to apt-get update (in dumb_update) #3

Closed
tfogwill opened this issue Sep 5, 2017 · 2 comments

Comments

@tfogwill
Copy link
Contributor

tfogwill commented Sep 5, 2017

Sometimes it is useful to be able to pass additional arguments to apt-get update (e.g. to handle bad proxies). It would be useful, for code using the API, to be able to pass these to dumb_update.

tfogwill added a commit to tfogwill/python-apt-mirror-updater that referenced this issue Sep 5, 2017
Added the ability to pass additional arguments to apt-get update in dumb_update.
See: xolox#3
xolox added a commit that referenced this issue Nov 1, 2017
This change set simplifies and improves the feature requested in
issue #3 and implemented in pull request #4 by switching from an
optional list argument to `star-args' and applying the same calling
convention to smart_update() as well.

This is backwards incompatible with the implementation in pull
request #4 (which I merged into the `dev' branch but never published
to PyPI) and it's also technically backwards incompatible in the
sense that keyword arguments could previously be given to
smart_update() as positional arguments. When I publish this I will
bump the major version number.
xolox added a commit that referenced this issue Nov 1, 2017
This release includes pull requests #2
and #4 and fixes issues #1 and #3.
@xolox
Copy link
Owner

xolox commented Nov 1, 2017

Hi @tfogwill and thanks for the suggestion, it makes sense.

I merged #4 but later decided to change the code so that dumb_update() and smart_update() accept zero or more positional arguments to pass to apt-get update (this feels more elegant to me than passing a list, see the changes in 2cbcaa2).

Release 5.0 was just uploaded to PyPI and contains these changes.

@xolox xolox closed this as completed Nov 1, 2017
@tfogwill
Copy link
Contributor Author

tfogwill commented Nov 2, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants