-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: allow passing of additional arguments to apt-get update (in dumb_update) #3
Comments
tfogwill
added a commit
to tfogwill/python-apt-mirror-updater
that referenced
this issue
Sep 5, 2017
Added the ability to pass additional arguments to apt-get update in dumb_update. See: xolox#3
xolox
added a commit
that referenced
this issue
Nov 1, 2017
This change set simplifies and improves the feature requested in issue #3 and implemented in pull request #4 by switching from an optional list argument to `star-args' and applying the same calling convention to smart_update() as well. This is backwards incompatible with the implementation in pull request #4 (which I merged into the `dev' branch but never published to PyPI) and it's also technically backwards incompatible in the sense that keyword arguments could previously be given to smart_update() as positional arguments. When I publish this I will bump the major version number.
xolox
added a commit
that referenced
this issue
Nov 1, 2017
Hi @tfogwill and thanks for the suggestion, it makes sense. I merged #4 but later decided to change the code so that Release 5.0 was just uploaded to PyPI and contains these changes. |
Hi. That makes sense - thanks for merging and improving.
…On 2 November 2017 at 00:09, Peter Odding ***@***.***> wrote:
Hi @tfogwill <https://github.com/tfogwill> and thanks for the suggestion,
it makes sense.
I merged #4 <#4>
but later decided to change the code so that dumb_update() and
smart_update() accept zero or more positional arguments to pass to apt-get
update (this feels more elegant to me than passing a list, see the
changes in 2cbcaa2
<2cbcaa2>
).
Release 5.0 was just uploaded to PyPI and contains these changes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGhgH3P9rz-ypwmsBJQO-g7Oq8LQmQmnks5syOwlgaJpZM4PNFOu>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sometimes it is useful to be able to pass additional arguments to apt-get update (e.g. to handle bad proxies). It would be useful, for code using the API, to be able to pass these to dumb_update.
The text was updated successfully, but these errors were encountered: