Prepare fiam for AGP upgrade. (firebase#4007)

* Remove redundant duplicate symbols * Move TestActivity to proper java package * Cleanup manifests and build files
xoeye · Aug 18, 2022 · 58c1677 · 58c1677
1 parent a65d648
commit 58c1677
Show file tree

Hide file tree

Showing 11 changed files with 6 additions and 53 deletions.
diff --git a/firebase-inappmessaging-display/firebase-inappmessaging-display.gradle b/firebase-inappmessaging-display/firebase-inappmessaging-display.gradle
@@ -43,8 +43,6 @@ android {
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8
         targetCompatibility JavaVersion.VERSION_1_8
-        // Neccesary for Dagger
-        incremental = false
     }
 
     sourceSets {

diff --git a/firebase-inappmessaging-display/src/androidTest/AndroidManifest.xml b/firebase-inappmessaging-display/src/androidTest/AndroidManifest.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.google.firebase.inappmessaging.display.internal.bindingwrappers">
+    package="com.google.firebase.inappmessaging.display.test">
 
   <application>
     <uses-library android:name="android.test.runner"/>
@@ -11,9 +11,4 @@
       </intent-filter>
     </activity>
   </application>
-
-  <instrumentation
-      android:name="androidx.test.runner.AndroidJUnitRunner"
-      android:targetPackage="com.google.firebase.inappmessaging.display.internal.bindingwrappers">
-  </instrumentation>
 </manifest>
diff --git a/...le/firebase/inappmessaging/display/internal/bindingwrappers/BannerBindingWrapperTest.java b/...le/firebase/inappmessaging/display/internal/bindingwrappers/BannerBindingWrapperTest.java
@@ -27,6 +27,7 @@
 import androidx.test.runner.AndroidJUnit4;
 import com.google.firebase.inappmessaging.display.internal.InAppMessageLayoutConfig;
 import com.google.firebase.inappmessaging.display.internal.injection.modules.InflaterConfigModule;
+import com.google.firebase.inappmessaging.display.test.TestActivity;
 import com.google.firebase.inappmessaging.model.Action;
 import java.util.HashMap;
 import java.util.Map;

diff --git a/...ogle/firebase/inappmessaging/display/internal/bindingwrappers/CardBindingWrapperTest.java b/...ogle/firebase/inappmessaging/display/internal/bindingwrappers/CardBindingWrapperTest.java
@@ -35,6 +35,7 @@
 import androidx.test.runner.AndroidJUnit4;
 import com.google.firebase.inappmessaging.display.internal.InAppMessageLayoutConfig;
 import com.google.firebase.inappmessaging.display.internal.injection.modules.InflaterConfigModule;
+import com.google.firebase.inappmessaging.display.test.TestActivity;
 import com.google.firebase.inappmessaging.model.Action;
 import com.google.firebase.inappmessaging.model.CardMessage;
 import java.util.HashMap;

diff --git a/...gle/firebase/inappmessaging/display/internal/bindingwrappers/ImageBindingWrapperTest.java b/...gle/firebase/inappmessaging/display/internal/bindingwrappers/ImageBindingWrapperTest.java
@@ -27,6 +27,7 @@
 import androidx.test.runner.AndroidJUnit4;
 import com.google.firebase.inappmessaging.display.internal.InAppMessageLayoutConfig;
 import com.google.firebase.inappmessaging.display.internal.injection.modules.InflaterConfigModule;
+import com.google.firebase.inappmessaging.display.test.TestActivity;
 import com.google.firebase.inappmessaging.model.Action;
 import java.util.HashMap;
 import java.util.Map;

diff --git a/...gle/firebase/inappmessaging/display/internal/bindingwrappers/ModalBindingWrapperTest.java b/...gle/firebase/inappmessaging/display/internal/bindingwrappers/ModalBindingWrapperTest.java
@@ -34,6 +34,7 @@
 import androidx.test.runner.AndroidJUnit4;
 import com.google.firebase.inappmessaging.display.internal.InAppMessageLayoutConfig;
 import com.google.firebase.inappmessaging.display.internal.injection.modules.InflaterConfigModule;
+import com.google.firebase.inappmessaging.display.test.TestActivity;
 import com.google.firebase.inappmessaging.model.Action;
 import com.google.firebase.inappmessaging.model.ModalMessage;
 import java.util.HashMap;

diff --git a/...nternal/bindingwrappers/TestActivity.java → ...pmessaging/display/test/TestActivity.java b/...nternal/bindingwrappers/TestActivity.java → ...pmessaging/display/test/TestActivity.java
@@ -11,8 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-
-package com.google.firebase.inappmessaging.display.internal.bindingwrappers;
+package com.google.firebase.inappmessaging.display.test;
 
 import android.app.Activity;
 

diff --git a/firebase-inappmessaging-display/src/main/res/drawable-anydpi-v21/btn_clear.xml b/firebase-inappmessaging-display/src/main/res/drawable-anydpi-v21/btn_clear.xml
diff --git a/firebase-inappmessaging-display/src/main/res/drawable-anydpi-v21/image_placeholder.xml b/firebase-inappmessaging-display/src/main/res/drawable-anydpi-v21/image_placeholder.xml
diff --git a/firebase-inappmessaging/firebase-inappmessaging.gradle b/firebase-inappmessaging/firebase-inappmessaging.gradle
@@ -85,8 +85,6 @@ android {
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_8
         targetCompatibility JavaVersion.VERSION_1_8
-        // Neccesary for Dagger
-        incremental = false
     }
     testOptions {
         unitTests {
@@ -95,15 +93,6 @@ android {
     }
 }
 
-configurations.all {
-    if(it.name.contains('AndroidTestRuntimeClasspath')) {
-        it.resolutionStrategy {
-            force 'org.checkerframework:checker-compat-qual:2.5.5'
-            force 'com.google.guava:guava:30.1.1-android'
-        }
-    }
-}
-
 
 thirdPartyLicenses {
     add 'Dagger', "${rootDir}/third_party/licenses/apache-2.0.txt"

diff --git a/firebase-inappmessaging/src/androidTest/AndroidManifest.xml b/firebase-inappmessaging/src/androidTest/AndroidManifest.xml
@@ -14,8 +14,4 @@
               android:value="com.google.firebase.components.ComponentRegistrar" />
     </service>
   </application>
-
-  <instrumentation
-      android:name="androidx.test.runner.AndroidJUnitRunner"
-      android:targetPackage="com.google.firebase.inappmessaging"/>
 </manifest>