Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare fiam for AGP upgrade. #4007

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Prepare fiam for AGP upgrade. #4007

merged 1 commit into from
Aug 18, 2022

Conversation

vkryachko
Copy link
Member

@vkryachko vkryachko commented Aug 18, 2022 •
edited
Loading

  • Remove redundant duplicate resources
  • Move TestActivity to proper java package
  • Cleanup manifests and build files

@vkryachko
Prepare fiam for AGP upgrade.
be963cf 
* Remove redundant duplicate symbols
* Move TestActivity to proper java package
* Cleanup manifests and build files
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (a65d648) and merge commit (5a1c1d9).

Test Logs

Notes

  • Commit (5a1c1d9) is created by Prow via merging PR base commit (a65d648) and head commit (be963cf).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QSaCBiGgGP.html

@github-actions
Copy link
Contributor

Unit Test Results

  28 files   -    309    28 suites   - 309   1m 1s ⏱️ - 13m 50s
313 tests  - 3 970  312 ✔️  - 3 949  1 💤  - 21  0 ❌ ±0 
313 runs   - 3 986  312 ✔️  - 3 965  1 💤  - 21  0 ❌ ±0 

Results for commit be963cf. ± Comparison against base commit a65d648f.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (a65d648) and merge commit (5a1c1d9).

Test Logs

Notes

  • Commit (5a1c1d9) is created by Prow via merging PR base commit (a65d648) and head commit (be963cf).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qMdIz1iEsS.html

@google-oss-bot
Copy link
Contributor

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests be963cf link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vkryachko vkryachko merged commit 58c1677 into master Aug 18, 2022
@vkryachko vkryachko deleted the vk.fiam_agp_fixes branch August 18, 2022 15:00
@firebase firebase locked and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@eldhosembabu eldhosembabu Awaiting requested review from eldhosembabu

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkryachko @google-oss-bot @rlazo