Remove explicit VEX coding from sad ASM #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shssoichiro
approved these changes
May 16, 2022
|
More specifically the macros defined in x86inc.asm, but yeah pretty much. |
|
The coveralls bot seems broken by the way, I mean how does code coverage change based on adding a couple spaces? |
|
I'm surprised coveralls is posting comments at all, given that their documentation said posting comments on PRs doesn't work with Github Actions. 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't initially see this problem in #2940. I believe executing VEX-encoded instructions on processors that don't support them (e.g., if it only supports sse2) will cause SIGILL.