core: Improve error message for unknown block successor #3762
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compor
reviewed
Jan 17, 2025
| "test.op"() [^unknown_successor]: () -> () | ||
| } | ||
|
|
||
| // CHECK: Unknown location of span region ends with missing block declarations for block(s) unknown_successor. |
There was a problem hiding this comment.
"span" is parser terminology, no? Same with "unknown location".
The block name could be in quotes - maybe have a look how we do it in other block references within error messages.
There was a problem hiding this comment.
This error message is definitely not correct.
alexarice
reviewed
Jan 17, 2025
| @@ -100,7 +100,7 @@ def __init__( | |||
| super().__init__(ParserState(MLIRLexer(Input(input, name))), ctx) | |||
| self.ssa_values = dict() | |||
| self.blocks = dict() | |||
| self.forward_block_references = dict() | |||
| self.forward_block_references = defaultdict(list) | |||
There was a problem hiding this comment.
What does this change do?
| @@ -145,7 +145,7 @@ def parse_module(self, allow_implicit_module: bool = True) -> ModuleOp: | |||
| value_names = ", ".join( | |||
| "%" + name for name in self.forward_ssa_references.keys() | |||
| ) | |||
| if len(self.forward_block_references.keys()) > 1: | |||
| if len(self.forward_ssa_references.keys()) > 1: | |||
There was a problem hiding this comment.
This looks like a separate change but I don't mind including it here.
| @@ -564,7 +564,7 @@ def parse_optional_region( | |||
| region.add_block(block) | |||
|
|
|||
| # Finally, check that all forward block references have been resolved. | |||
| if len(self.forward_block_references) > 0: | |||
| if self.forward_block_references: | |||
| pos = self.lexer.pos | |||
There was a problem hiding this comment.
This should probably be self.pos?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the error message more specific where an unknown successor is encountered.