[WIP]: Initialise arm_cf and begin beq implementation #3760
+98
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been stuck on this error for a while now so just pushing this as WIP in case anyone could help speed things up: |
alexarice
reviewed
Jan 17, 2025
|
|
||
| // CHECK-NEXT: arm_cf.beq %x1, %x2, ^testlabel | ||
| // CHECK-ASM: arm_cf.beq x1, x2, ^testlabel | ||
| arm_cf.beq %x1, %x2, ^testlabel : (!arm.reg<x1>, !arm.reg<x2>) |
There was a problem hiding this comment.
I think the issue is you've that you've referred to a block that doesn't exist
There was a problem hiding this comment.
This is a good opportunity to fix the error message in a separate PR!
There was a problem hiding this comment.
PR for fixing error message: #3762
superlopuh
reviewed
Jan 17, 2025
| def assembly_line_args(self): | ||
| then_label = self.then_block.first_op | ||
| assert isinstance(then_label, arm.ops.LabelOp) | ||
| return (self.s1, self.s2, then_label.label.data) |
There was a problem hiding this comment.
It would be good to allow both str and StringAttr here
Suggested change
| return (self.s1, self.s2, then_label.label.data) | |
| return (self.s1, self.s2, then_label.label) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add arm_cf dialect and implement beq instruction