This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix RTL on Labels with FormattedText and/or LineHeight #13197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @rachelkang the project isn't building, seems something wrong in the csproj |
rmarinho
reviewed
Dec 23, 2020
...s.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
Show resolved
Hide resolved
jsuarezruiz
suggested changes
Jan 14, 2021
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3311.cs
Outdated
Show resolved
Hide resolved
Fix RTL issue that arises when certain text properties are set on a Label w/ RTL and FormattedText (i.e. FontAttributes, FontSize, LineHeight, TextColor, TextTransform, etc)
TextType on FormattedText labels causes app crash. This separate issue will be fixed in a follow-up PR
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Redth
approved these changes
Jan 27, 2021
jsuarezruiz
approved these changes
Jan 27, 2021
|
Arabic text is reversed "mirrored" if i used it as EmptyView for CollectionView |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix RTL so that it works on labels with FormattedText and/or LineHeight
Fix RTL so that it works on labels with other previously incompatible properties as well (i.e. FontAttributes, FontSize, LineHeight, TextColor, TextTransform, TextType, VerticalTextAlignment)
Issues Resolved
Platforms Affected
Behavioral/Visual Changes
Labels with RTL (and with FormattedText and/or LineHeight) are properly right-aligned now
Before/After Screenshots
Testing Procedure
Issue3311Issue12743RTLLabelWithFormattedTextWorksandRTLLabelWithLineHeightWorkstests are passingPR Checklist