fix: catch crash in dev server (fixes #1297) #1441
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes wxt-dev#1297. Catch exception in `findEntrypoints` when reloading changed files in dev server.
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@aleclarson I know you opened #1437, thoughts on this vs your PR? |
|
@aklinker1 This is certainly a simpler solution, though does the error actually get logged? And what does that look like? Also, this PR doesn't handle syntax errors that occur on startup; only afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1297.
Catch exception in
findEntrypointswhen reloading changed files in dev server.Overview
This fixes a problem where the dev server would crash on syntax errors when reloading changed files. The crash occurs due to an exception in the Babel parser which is invoked for finding the entrypoints. The fix is moving the call to findEntrypoints to the try block, where an exception would be caught - just like the rest of the reload logic.
Manual Testing
I have a project which would crash every few minutes while editing in VSCode. After the fix the crashes are gone and the reload works.
Related Issue
This PR closes #1297