feat: tolerate syntax errors #1437
Open
+62
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Avoid crashing the dev server on syntax errors.
NOTE: Only syntax errors from the Babel parser are supported currently. We should also handle any other common parsers.
Manual Testing
Two cases are handled by this PR:
In both cases, WXT currently crashes and you need to restart it manually.
With this PR, both cases are logged (including filename and location of the syntax error). When the offending file is fixed, the dev server continues like nothing ever happened. 🎉
Screenshots
Syntax error on dev server startup
After fixing the syntax error
Related Issue
Closes #1297