Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #522: Maximum number of presence check attempts is off by 1 #523

Merged
merged 1 commit into from
Nov 11, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix #522: Maximum number of presence check attempts is off by 1
  • Loading branch information
romanstrobl committed Nov 11, 2022
commit 86a0ddbdea79849763c94b8c729da0b33baba819
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public PresenceCheckLimitService(
public void checkPresenceCheckMaxAttemptLimit(OwnerId ownerId, String processId) throws IdentityVerificationException, PresenceCheckLimitException, RemoteCommunicationException {
final int otpCount = otpRepository.countByProcessIdAndType(processId, OtpType.USER_VERIFICATION);
// TODO (racansky, 2022-10-20, #453) OTP verification could be turned off, logic should be based on another data
if (otpCount > identityVerificationConfig.getPresenceCheckMaxFailedAttempts()) {
if (otpCount >= identityVerificationConfig.getPresenceCheckMaxFailedAttempts()) {
final IdentityVerificationEntity identityVerification = identityVerificationRepository.findFirstByActivationIdOrderByTimestampCreatedDesc(ownerId.getActivationId())
.orElseThrow(() ->
new IdentityVerificationException("Identity verification was not found, " + ownerId));
Expand Down