Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #522: Maximum number of presence check attempts is off by 1 #523

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Fix #522: Maximum number of presence check attempts is off by 1 #523

merged 1 commit into from
Nov 11, 2022

Conversation

romanstrobl
Copy link
Member

The issue is caused by the OTP being generated at the end, however the check is in the beginning, so 1 OTP attempt needs to be subtracted.

@romanstrobl romanstrobl added the bug Something isn't working label Nov 11, 2022
@romanstrobl romanstrobl requested a review from banterCZ November 11, 2022 14:24
@romanstrobl romanstrobl self-assigned this Nov 11, 2022
banterCZ
banterCZ approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@romanstrobl romanstrobl merged commit 538af0b into develop Nov 11, 2022
@romanstrobl romanstrobl deleted the issues/522-presence-check-count-off branch November 11, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banterCZ banterCZ banterCZ approved these changes

Assignees

@romanstrobl romanstrobl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanstrobl @banterCZ