Fix #311: Improve detection of failed presence check

[romanstrobl]

This pull requests adds an error_origin column which is used for auditing purposes as well as for checking overall OTP verification result during SCA step (failure due to presence check error).

DDL update:

alter table es_document_result add column error_origin VARCHAR(256);
alter table es_document_verification add column error_origin VARCHAR(256);
alter table es_identity_verification add column error_origin VARCHAR(256);
alter table es_onboarding_otp add column error_origin VARCHAR(256);
alter table es_onboarding_process add column error_origin VARCHAR(256);

alter table es_document_result add column reject_origin VARCHAR(256);
alter table es_document_verification add column reject_origin VARCHAR(256);
alter table es_identity_verification add column reject_origin VARCHAR(256);

[saalistaja]

Nice addition of a new field to track error/rejection origin.

I am just not sure with the shared naming, used for rejectReason too.

Furthermore rhere seems to be left several places in the code with setRejectReason but without setting an origin, is this desired?

[romanstrobl]

Ok, we can extend the logic for the sake of completeness:

• add reject_origin column
• always set reject_origin when setting reject_reason
• always separate handling for rejection and errors

[romanstrobl]

@saalistaja Please check the changes now. We will also need to merge the changes with state machine logic, I can try to do it, but I think it will be easier for you?

[saalistaja]

Last round of review. I am not sure with one condition.

[saalistaja]

Shouldn't we fix this to
(errorOrigin == ErrorOrigin.PRESENCE_CHECK && StringUtils.isNotBlank(errorDetail)) || (rejectOrigin == ErrorOrigin.PRESENCE_CHECK && StringUtils.isNotBlank(rejectReason)) ?

[romanstrobl]

Yes, true.

[saalistaja]

Well done!