Resolve #304: Introduce state machine approach #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saalistaja
commented
Apr 25, 2022
•
- Refactored previous approach to spring state machine
- Mapped current phase, status to new onboarding state enums
- Transitions triggered by simple events from controllers and one technical event for auto-transition on status check
Add tests for OTP verification transitions
added 3 commits
August 16, 2022 15:15
Adapt document verification tests to the latest changes
- Mark as choice state PRESENCE_CHECK_FAILED and PRESENCE_CHECK_REJECTED
romanstrobl
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
In general, these changes are exactly what we needed to improve the state handling in the application. I found several minor issues which are related to consistency, several minor performance improvements and ideas. Feel free to ignore if you disagree with proposed changes.
...arding/src/main/java/com/wultra/app/onboardingserver/statemachine/util/StateContextUtil.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/wultra/app/onboardingserver/statemachine/service/StateMachineService.java
Outdated
Show resolved
Hide resolved
.../com/wultra/app/onboardingserver/statemachine/interceptor/CustomStateMachineInterceptor.java
Outdated
Show resolved
Hide resolved
...com/wultra/app/onboardingserver/statemachine/action/verification/VerificationInitAction.java
Outdated
Show resolved
Hide resolved
...nboarding/src/main/java/com/wultra/app/onboardingserver/statemachine/StateMachineConfig.java
Outdated
Show resolved
Hide resolved
| jsonSerializationService.deserialize(identityVerification.getSessionInfo(), SessionInfo.class); | ||
| if (sessionInfo == null) { | ||
| logger.error("Checking presence verification failed due to invalid session info, {}", ownerId); | ||
| identityVerification.setErrorDetail("Unable to deserialize session info"); |
There was a problem hiding this comment.
Just a note to myself, we'll need to also add the error origin due to parallel pull request: #315
...main/java/com/wultra/app/onboardingserver/controller/api/IdentityVerificationController.java
Outdated
Show resolved
Hide resolved
...main/java/com/wultra/app/onboardingserver/controller/api/IdentityVerificationController.java
Outdated
Show resolved
Hide resolved
...oarding/src/main/java/com/wultra/app/onboardingserver/impl/service/PresenceCheckService.java
Outdated
Show resolved
Hide resolved
|
@romanstrobl Thanks for the feedback. I have fixed all the found issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.