Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the manifest section #6

Merged
merged 4 commits into from
Aug 20, 2021

Conversation

felipeerias
Copy link
Collaborator

This PR removes the manifest section.

The motivation is to factor the "core" Web Bundles specification to include just the minimal amount needed to support cases like subresource loading, which does not need a manifest. This and other removed sections can be defined in other documents in the future.

Adapted from WICG/webpackage#619

The idea of this PR is that the "core" Web Bundles specification does not
include the manifest sections, but that these sections can be defined in other
documents. The motivation is to factor the Web Bundles specification to include
just the minimal amount needed to support cases like subresource loading.
Subresource loading does not need a manifest.

Adapted from WICG/webpackage#619
@felipeerias felipeerias requested a review from jyasskin as a code owner July 5, 2021 02:40
@hayatoito
Copy link
Collaborator

We might want to make sure the impact of removing manifest section from the bundle format on the chromium.

@horo-t @irori
Does Chrome have any usages of manifest section? It seems Navigate to Bundle doesn't use it, however, I am wondering whether there is existing use case for that, I am not aware of.

@littledan
Copy link
Collaborator

I never really understood the motivation of this section, since the primary URL response can contain a header pointing to the manifest.

@horo-t
Copy link
Collaborator

horo-t commented Jul 7, 2021

Imagine the situation of application distribution, it is very useful to have a manifest section. For example, we can display the application icon without parsing the HTML of the primary URL.
But I agree that the manifest section can be outside the scope of the "core" bundle specification.
So removing it from the core spec looks good to me.

Copy link
Collaborator

@hayatoito hayatoito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just for record). Thanks for working on this.

@felipeerias felipeerias merged commit 4d642a6 into wpack-wg:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants