Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the manifest and critical sections #619

Closed
wants to merge 1 commit into from

Conversation

littledan
Copy link
Contributor

The idea of this PR is that the "core" Web Bundles specification does not include the manifest or critical sections, but that these sections can be defined in other documents. The motivation is to factor the Web Bundles specification to include just the minimal amount needed to support cases like subresource loading. Subresource loading does not need a manifest. For the critical section, if it is missing, the behavior is likely to be to not require any sections, so it can also be defined and interpreted just where it is needed for more detailed bundle types.

The idea of this PR is that the "core" Web Bundles specification does not include the manifest or critical sections, but that these sections can be defined in other documents. The motivation is to factor the Web Bundles specification to include just the minimal amount needed to support cases like subresource loading. Subresource loading does not need a manifest. For the critical section, if it is missing, the behavior is likely to be to not require any sections, so it can also be defined and interpreted just where it is needed for more detailed bundle types.
@jyasskin
Copy link
Member

jyasskin commented Feb 9, 2021

I'm friendly to the idea of pulling "manifest" out to an extension document, like we're doing for "signatures".

I feel like "critical" needs to be in the core spec in order to be worth having at all, since its purpose is to be able to get all implementations to reject a bundle with a section they don't understand. It's possible we could replace the "critical" section entirely with your idea around defining an HTTP header to negotiate it, but we should make sure that's likely to work before deciding to get rid of the "critical" section.

@jyasskin jyasskin added the discuss Needs a verbal or face-to-face discussion label Feb 9, 2021
@littledan
Copy link
Contributor Author

Yeah, maybe this should've been two separate PRs. I don't fully understand the full story around the "critical" section, and don't feel strongly that it needs to be removed; "discuss" seems like an appropriate label.

Base automatically changed from master to main February 17, 2021 00:19
felipeerias added a commit to felipeerias/bundled-responses that referenced this pull request Jul 2, 2021
The idea of this PR is that the "core" Web Bundles specification does not
include the manifest sections, but that these sections can be defined in other
documents. The motivation is to factor the Web Bundles specification to include
just the minimal amount needed to support cases like subresource loading.
Subresource loading does not need a manifest.

Adapted from WICG/webpackage#619
@hayatoito
Copy link
Collaborator

I think we can close this PR, in favor of wpack-wg/bundled-responses#6

@hayatoito hayatoito closed this Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Needs a verbal or face-to-face discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants