Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Quote block styles regression and Visual tests updates #6790

Merged
merged 7 commits into from
Apr 10, 2024
Merged

Fix Quote block styles regression and Visual tests updates #6790

merged 7 commits into from
Apr 10, 2024

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Apr 4, 2024 •
edited
Loading

Related PRs:

This PR addresses a few issues:

  • Fixes a Quote Block regression related to styling for both standard and block-based themes.
  • Updates the snapshot for the Gutenberg Editor Writing Flow should format pasted HTML test due to new HTML attributes that were added.
  • Updates Gallery block visual test images and snapshots to prevent flakiness in CI.

To test all CI checks should pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the bugfix label Apr 4, 2024
@geriux geriux added this to the 1.117.0 (24.7) milestone Apr 4, 2024
@geriux geriux mentioned this pull request Apr 4, 2024
Merged
@geriux geriux changed the title Fix Quote block styles regression Fix Quote block styles regression and Visual tests updates Apr 5, 2024
@geriux geriux requested a review from twstokes April 5, 2024 14:53
twstokes
twstokes approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@geriux geriux enabled auto-merge April 10, 2024 15:39
@geriux geriux merged commit fbeed75 into trunk Apr 10, 2024
19 of 20 checks passed
@geriux geriux deleted the fix/quote-styles-regression branch April 10, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twstokes twstokes twstokes approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
1.117.0 (24.7)
Development

Successfully merging this pull request may close these issues.
2 participants
@geriux @twstokes