[Mobile] - Fix Quote Block styles #60476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 4, 2024 19:01
|
Size Change: +677 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
Merged
2 tasks
added 2 commits
April 5, 2024 16:17
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
Addresses styling regression after recent changes in #59073
Why?
To show the expected styles for this block.
How?
By setting the
tagNamefor the Citation component as well as updating theBlockQuotationcomponent to use theattributeKeyidentifier as a fallback as well as updating some styles.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
Note
The first block is a Quote block with a citation, the second block is a Quote block with two paragraphs without a citation.