Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary <strong> tags from post title #577

Merged
merged 3 commits into from
Feb 8, 2019

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Feb 8, 2019

This is a quick workaround to remove <strong> tags from post title. We can see those tags on Aztec editor.

title-strong-tag2

Changes reside in WordPress/gutenberg#13763

To Test

Test both on WPAndroid and WPiOS
Main apps PRs: wpandroid, wpios.

  1. Test with a new post
  • Open a new post
  • Type a title
  • Switch to Classic editor
  • Verify that you don't see <strong> tags
  1. Test with an existing post
  • Open an existing post with a title
  • Switch to Classic editor
  • Verify that you don't see <strong> tags
  1. Test we don't affect other blocks
  • Open a post and add a paragraph/heading block
  • Select all and make bold
  • Switch to classic editor and see boldness didn't get lost

@pinarol pinarol self-assigned this Feb 8, 2019
@pinarol pinarol added this to the Beta milestone Feb 8, 2019
@daniloercoli
Copy link
Contributor

Tested on wp-android (by using the branch pointed above, and then updating the ref to this branch), and it worked fine!

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce the original issue and this effectively fixes the problem. 🎉
Tested on WPiOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants