Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gutenberg ref to release 0.3.5 #10969

Merged
merged 9 commits into from
Feb 8, 2019
Merged

Bump Gutenberg ref to release 0.3.5 #10969

merged 9 commits into from
Feb 8, 2019

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Feb 7, 2019

Bump Gutenberg ref to release 0.3.5

To test:

Also try some basic functionality on blocks.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@pinarol pinarol added the Gutenberg Editing and display of Gutenberg blocks. label Feb 7, 2019
@pinarol pinarol added this to the 11.8 milestone Feb 7, 2019
@pinarol pinarol self-assigned this Feb 7, 2019
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found two issues:

  1. Pressing shift + ENTER while the caret is in the title causes a red screen. (issue)
  2. Can't switch from Aztec to Gutenberg on a post with a title but no content. (issue)

Neither of these IMO should hold back the release, since the shift + ENTER one requires a hardware keyboard and I believe users won't see the red screen.

The second issue isn't critical, and wasn't introduced by this PR.

I'll update this comment as soon as I create issues for those two points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants