Enable Inserter Block Search #3735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Inserter Block Search note
This was referenced Jul 19, 2021
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
7 tasks
guarani
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
Approved via WordPress/gutenberg#33559 (review), I left one nitpick here but not a blocker.
| @@ -1,5 +1,6 @@ | |||
| Unreleased | |||
| ------ | |||
| * [***] Add Inserter Block Search [https://github.com/wordpress-mobile/gutenberg-mobile/issues/2570] | |||
There was a problem hiding this comment.
nitpick: It might be beneficial to editorial to have a more descriptive (longer, more explicit) release note that they can shorten down. The link doesn't provide much detail on how this feature looked in the end, so I don't think they'll find much additional information there.
|
Given the feedback regarding the Android bottom sheet animation I'm nocking this one back to the next release. |
|
Closing in favor of #3867 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR WordPress/gutenberg#33559
To test:
Follow test steps here WordPress/gutenberg#33237
PR submission checklist: