[RNmobile] Enable inserter block search #33559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.2 kB (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
2 tasks
jhnstn
commented
Jul 30, 2021
| @@ -45,7 +45,10 @@ import BottomSheetSubSheet from './sub-sheet'; | |||
| import NavigationHeader from './navigation-header'; | |||
| import { BottomSheetProvider } from './bottom-sheet-context'; | |||
|
|
|||
| const DEFAULT_LAYOUT_ANIMATION = LayoutAnimation.Presets.easeInEaseOut; | |||
| const DEFAULT_LAYOUT_ANIMATION_PROPERTIES = { | |||
There was a problem hiding this comment.
See the comment in the description regarding the reason for this change.
The issue only affects Android but the code path to the default animation is only followed by Android.
iOS is following the keyboard specific animation setup ( around line 123 in this diff ).
Regarding that, I did try to force Android into using the keyboard animation type. The RN docs do not say that that animation type is iOS only but I kept running into this issue facebook/react-native#27839 ( I too confirmed that UIManager.setLayoutAnimationEnabledExperimental(true) is set up correctly ).
guarani
approved these changes
Jul 30, 2021
fluiddot
reviewed
Aug 2, 2021
There was a problem hiding this comment.
On iOS, it works perfect but on Android, I noticed that we still have some visual glitches in the transition (see attached video capture), have you experienced this too? is it expected?
Tested on Samsung Galaxy S20 FE 5G (Android 10) with production JS bundle served via Metro.
Screen_Recording_20210802-110507_WordPress.Pre-Alpha.mp4
|
@fluiddot I'm seeing the same issues and flagged them with @jhnstn as a "blocker" for shipping this feature. We've been discussing some possible (Android-specific) workarounds and whether or not we should ship as-is then iterate to fix these animation issues. Regarding potential workarounds, I was thinking yesterday about how we might work around the height transition bugs by limiting the number of height transitions. I'm not 100% sure if I like this option because of the downsides I'll mention below, but one option I explored was going straight to the full-height sheet when the user taps the There are some downsides to that approach:
Here's a blueprint to help visualize this flow:
|
|
closing in favor of #34129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables the Inserter Block search feature on mobile Gutenberg.
Gutenberg Mobile companion PR wordpress-mobile/gutenberg-mobile#3735
How has this been tested?
The feature has been tested in #33237
Screenshots
Types of changes
Replace
__DEV__flag withtrueto enable the inserter search in production builds.It also addresses some feedback from @iamthomasbishop (wordpress-mobile/WordPress-Android#15044 (comment) ):
easeInEaseOuttoeaseInand lowering the duration from300to150. The idea is to reduce the attention that the existing animation draws while still preventing the visual glitch when the keyboard opens.Checklist:
*.native.jsfiles for terms that need renaming or removal).