Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merge of preformatted blocks #1636

Merged
merged 5 commits into from
Dec 5, 2019
Merged

Fix merge of preformatted blocks #1636

merged 5 commits into from
Dec 5, 2019

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Nov 28, 2019 •
edited
Loading

Fixes #18476 for mobile RN

GB PR: WordPress/gutenberg#18809

To test:

  • Add two preformatted blocks
  • Write several lines on each
  • Merge them
  • See if whitespace is kept properly

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@SergioEstevao SergioEstevao added the [Type] Bug Something isn't working label Nov 28, 2019
@SergioEstevao SergioEstevao added this to the 1.19 milestone Nov 28, 2019
@SergioEstevao SergioEstevao mentioned this pull request Nov 28, 2019
Merged
6 tasks
marecar3
marecar3 approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on both iOS and Android and it's working as expected! Nice work! :)
LGTM!

@SergioEstevao SergioEstevao merged commit f1dc8d5 into develop Dec 5, 2019
@SergioEstevao SergioEstevao deleted the issue/fix_merge_of_preformatted_blocks branch December 5, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

@mchowning mchowning Awaiting requested review from mchowning

Assignees
No one assigned
Labels
[Type] Bug Something isn't working
Projects
None yet
Milestone
1.19
Development

Successfully merging this pull request may close these issues.
2 participants
@SergioEstevao @marecar3