Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preserve white space to the native version. #18809

Merged
merged 2 commits into from
Nov 29, 2019

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Nov 28, 2019

Description

Fixes #18476 for mobile RN

Brings the preserve white space prop to the mobile version has done here for web: #18656

How has this been tested?

This can be tested using the Mobile version here: wordpress-mobile/gutenberg-mobile#1636

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@SergioEstevao SergioEstevao added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Nov 28, 2019
@SergioEstevao SergioEstevao added this to the Future milestone Nov 28, 2019
@SergioEstevao SergioEstevao merged commit d385ec1 into master Nov 29, 2019
@SergioEstevao SergioEstevao deleted the rnmobile/rich_text_add-preserveWhiteSpace branch November 29, 2019 11:51
@youknowriad youknowriad modified the milestones: Future, Gutenberg 7.1 Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge between Preformatted and Paragraph blocks is removing all newlines.
3 participants