Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from project-chip:master #574

Merged
merged 17 commits into from
May 15, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented May 14, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

woody-apple and others added 3 commits May 13, 2024 17:15
…and the I/O buffer (#33396)

* Split out ember-compatibiltiy-functions with some shareable bits.

When looking to implement the ember/codegen data mode, some
functionality in ember-compatibility-functions needs sharing to
avoid extra copy&paste bloat:

- Global attribute handling via AAI split into a separate file
- Raw "data I/O" buffer split into a separate file

Moved privilege-storage and implemented a few more mock ember
methods.

* Also update linter

* Remove obsolete file

* Fix odd include

* Add files to Matter.xcodeproject

* Update src/app/util/ember-io-storage.h

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Update ember-io-storage.h

Add additional comments.

* Restyle

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Copy link

guardrails bot commented May 14, 2024

⚠️ We detected 1 security issue in this pull request:

Insecure Processing of Data (1)
Severity Details Docs
High Title: NULL Pointer Dereference
gEmberAttributeIOBufferSpan.data(), attributeMetadata->attributeType);
📚

More info on how to fix Insecure Processing of Data in C/C++.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

* Make test suite setup and teardown functions static

* Restyled by clang-format

* Fixed bug in LoopbackTransport initialization

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Pointer to the ThreadDiagnosticsDelegate is used without a null
check. It leads to the usage fault, if ThreadNetworkDiagnostics
cluster is disabled and pointer is set to nullptr.
…t on efr… (#33430)

* Fix efr32 test driver event loop, run gtests, enable more test on efr32 test drivers

* add github issue in comments
yufengwangca and others added 2 commits May 14, 2024 19:19
…ynchronization (#33393)

* Initial implementation of fabric-admin app

* Address review comments
@github-actions github-actions bot added the tools label May 14, 2024
bzbarsky-apple and others added 5 commits May 14, 2024 16:39
We no longer seem to get a useful PWD when running tests, so stop using it.
Signed-off-by: Martin Girardot <martin.girardot@nxp.com>
- The debug logging in metrics collector is very noisy and debug is
  enabled by default.
- Disabling the metrics debug logging since it is not really useful
  except for developer development mode debugging, which is recompile
  and test.
@github-actions github-actions bot added the ble label May 15, 2024
@woody-apple woody-apple merged commit eef8ea4 into woody-apple:master May 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment