-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated chip-cert-bins Dockerfile #33448
Merged
andy31415
merged 1 commit into
project-chip:master
from
rquidute:update_chip_cert_bins-dockerfile
May 14, 2024
Merged
Updated chip-cert-bins Dockerfile #33448
andy31415
merged 1 commit into
project-chip:master
from
rquidute:update_chip_cert_bins-dockerfile
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@andy31415 @cecille Can you guys take a look please ? Just to make sure our docker images from mainline also don't run into the same issue we faced on the 1.3 branch . |
raju-apple
approved these changes
May 14, 2024
PR #33448: Size comparison from 878fbb7 to 0fa456b Decreases (2 builds for efr32)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
yufengwangca
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was copied from #33015, since it was not merged into master branch.
Fixes #32989
Changes
Do not needlesly clear apt update results, as it is reused and a build image will not copy over their contents anyway
Update compile of bloaty to use ninja, so we do not hardcode -j8
Install openjdk8 before installing chip whl, since apparently we depend on mason which depends on the jdk