Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Nextcloud also secured it's actions with zizmor #415

Merged
merged 1 commit into from
Jan 10, 2025
Merged

docs: Nextcloud also secured it's actions with zizmor #415

merged 1 commit into from
Jan 10, 2025

Conversation

nickvergessen
Copy link
Contributor

Thanks a lot for the great tool :)

@nickvergessen
docs: Nextcloud also secured it's actions with zizmor
8e0b7b9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
woodruffw
woodruffw approved these changes Jan 10, 2025
View reviewed changes
Copy link
Owner

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickvergessen!

@woodruffw woodruffw enabled auto-merge (squash) January 10, 2025 15:41
@woodruffw woodruffw added the documentation Improvements or additions to documentation label Jan 10, 2025
@woodruffw woodruffw merged commit 8b43ed0 into woodruffw:main Jan 10, 2025
5 checks passed
@nickvergessen nickvergessen deleted the patch-1 branch January 10, 2025 16:08
@nickvergessen
Copy link
Contributor Author

Hmm the . seems to cause weird things:

grafik

It also had an error at the beginning when I tried to run make trophies Maybe you need to adjust a regex somewhere 🙈

@woodruffw
Copy link
Owner

Hah. Yeah, let me see about tweaking that. Thanks regardless for updating the trophy, I appreciate it!

@woodruffw
Copy link
Owner

Huh, this looks like it's probably a bug in MagicLink: {user}/{repo}#num should always work: https://facelessuser.github.io/pymdown-extensions/extensions/magiclink/#issues-pull-requests-and-discussions

I'll file an upstream issue.

@woodruffw woodruffw mentioned this pull request Jan 10, 2025
Closed
@woodruffw
Copy link
Owner

Fixed upstream: facelessuser/pymdown-extensions#2563, so this should be fixed for us whenever the dep rolls over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @woodruffw