-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MagicLink doesn't link user/.github#num
correctly
#2562
Comments
Yes, this is a bug. We were including an unnecessary check that the repo has a word boundary at the start, but since repos can start with Anyway, the fix is pretty easy and I should have one up sometime soon. |
Awesome, thanks for confirming! Please let me know if there's anything else I can do. |
Above linked PR provides the fix for this issue. |
Description
Hi there, thanks for this extension set! I'm a very happy user.
I noticed what I think is a MagicLink bug in
zizmor
's documentation, appearing with woodruffw/zizmor#415: it looks likeuser/.github#num
doesn't appear to recognizeuser/.github
as theuser/repo
slug, and instead sees it as{default_user}/github#num
.For example,
nextcloud/.github#477
is included here and gets linked incorrectly tohttps://github.com/woodruffw/github/issues/477
, instead ofhttps://github.com/nextcloud/.github/issues/477
.Some additional details here: woodruffw/zizmor#415
Minimal Reproduction
user/.github#num
as a MagicLink{default_user}/github#num
instead ofuser/.github#num
Version(s) & System Info
The text was updated successfully, but these errors were encountered: