Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose cmd to docker compose. #3709

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

rafaelzaleski
Copy link
Contributor

@rafaelzaleski rafaelzaleski commented Jan 10, 2025

Changes proposed in this Pull Request:

  • Commands executing docker-compose (Compose V1) have been replaced with docker compose (Compose V2)

Testing instructions

  • Run npm run up locally and verify that the development environment installs without errors.

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

@rafaelzaleski rafaelzaleski self-assigned this Jan 10, 2025
@rafaelzaleski rafaelzaleski marked this pull request as ready for review January 10, 2025 17:04
@rafaelzaleski rafaelzaleski requested review from a team and diegocurbelo and removed request for a team January 10, 2025 19:56
Copy link
Member

@diegocurbelo diegocurbelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@rafaelzaleski rafaelzaleski merged commit 15b8cd5 into develop Jan 13, 2025
35 of 37 checks passed
@rafaelzaleski rafaelzaleski deleted the chore/update-docker-compose-command branch January 13, 2025 22:27
hsingyuc pushed a commit that referenced this pull request Jan 27, 2025
Co-authored-by: Diego Curbelo <diego@curbelo.com>
hsingyuc added a commit that referenced this pull request Jan 29, 2025
* Lint fixes (#3673)

* Lint fixes

---------

Co-authored-by: nbloomf <nathan.bloomfield@automattic.com>
Co-authored-by: Anne Mirasol <anne.mirasol@automattic.com>

* Fix excessive emails when enabling the gateway (#3695)

* Fix duplicate emails when enabling the gateway

During payment gateway initialization, WC core adds hooks that will get
triggered when the main gateway is enabled. Using a centralized option_key for all
'child gateways' makes WC core issue separate email notifications for all of them. To sidestep this problem,
with this change, we use separate option_id for each child gateway but still use the
parent gateway settings when retrieving them.

Changes made:
- Update get_option_key() to return settings specific to the Stripe ID.
- Introduce get_option() method to fetch options from the main Stripe gateway.

---------

Co-authored-by: Mayisha <33387139+Mayisha@users.noreply.github.com>

* New headers for changelog and readme files

* Update docker-compose cmd to docker compose. (#3709)

Co-authored-by: Diego Curbelo <diego@curbelo.com>

* Pass total tax amount to metadata

* Add changelog entry

* Update unit test

---------

Co-authored-by: Nathan Bloomfield <nathan.bloomfield@a8c.com>
Co-authored-by: nbloomf <nathan.bloomfield@automattic.com>
Co-authored-by: Anne Mirasol <anne.mirasol@automattic.com>
Co-authored-by: Malith Senaweera <6216000+malithsen@users.noreply.github.com>
Co-authored-by: Mayisha <33387139+Mayisha@users.noreply.github.com>
Co-authored-by: Wesley Rosa <wesleyjrosa@gmail.com>
Co-authored-by: Rafael Zaleski <rafaelzaleski@users.noreply.github.com>
Co-authored-by: Diego Curbelo <diego@curbelo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants