Lint fixes #3673
Merged
Lint fixes #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b6723c4 to
d9ec55c
Compare
annemirasol
approved these changes
Jan 2, 2025
| @@ -1101,7 +1101,7 @@ public function confirm_change_payment_from_setup_intent_ajax() { | |||
| throw new WC_Stripe_Exception( 'subscription_not_found', __( "We're not able to process this subscription change payment request payment. Please try again later.", 'woocommerce-gateway-stripe' ) ); | |||
| } | |||
|
|
|||
| $setup_intent_id = isset( $_POST['intent_id'] ) ? wc_clean( wp_unslash( $_POST['intent_id'] ) ) : null; | |||
| $setup_intent_id = ( isset( $_POST['intent_id'] ) && is_string( $_POST['intent_id'] ) ) ? sanitize_text_field( wp_unslash( $_POST['intent_id'] ) ) : null; | |||
There was a problem hiding this comment.
I think this is fine. We do expect a valid $_POST['intent_id'] to be a string.
e26baa2 to
362476e
Compare
nbloomf
commented
Jan 8, 2025
| require_once __DIR__ . '/includes/admin/class-wc-stripe-upe-compatibility-controller.php'; | ||
| require_once __DIR__ . '/includes/migrations/class-allowed-payment-request-button-types-update.php'; | ||
| require_once __DIR__ . '/includes/class-wc-stripe-account.php'; | ||
|
|
||
| new Allowed_Payment_Request_Button_Types_Update(); |
There was a problem hiding this comment.
There were some file path changes that required a rebase here; I used diff to make sure the names match.
166df50 to
fc98af3
Compare
hsingyuc
pushed a commit
that referenced
this pull request
Jan 27, 2025
* Lint fixes --------- Co-authored-by: nbloomf <nathan.bloomfield@automattic.com> Co-authored-by: Anne Mirasol <anne.mirasol@automattic.com>
hsingyuc
added a commit
that referenced
this pull request
Jan 29, 2025
* Lint fixes (#3673) * Lint fixes --------- Co-authored-by: nbloomf <nathan.bloomfield@automattic.com> Co-authored-by: Anne Mirasol <anne.mirasol@automattic.com> * Fix excessive emails when enabling the gateway (#3695) * Fix duplicate emails when enabling the gateway During payment gateway initialization, WC core adds hooks that will get triggered when the main gateway is enabled. Using a centralized option_key for all 'child gateways' makes WC core issue separate email notifications for all of them. To sidestep this problem, with this change, we use separate option_id for each child gateway but still use the parent gateway settings when retrieving them. Changes made: - Update get_option_key() to return settings specific to the Stripe ID. - Introduce get_option() method to fetch options from the main Stripe gateway. --------- Co-authored-by: Mayisha <33387139+Mayisha@users.noreply.github.com> * New headers for changelog and readme files * Update docker-compose cmd to docker compose. (#3709) Co-authored-by: Diego Curbelo <diego@curbelo.com> * Pass total tax amount to metadata * Add changelog entry * Update unit test --------- Co-authored-by: Nathan Bloomfield <nathan.bloomfield@a8c.com> Co-authored-by: nbloomf <nathan.bloomfield@automattic.com> Co-authored-by: Anne Mirasol <anne.mirasol@automattic.com> Co-authored-by: Malith Senaweera <6216000+malithsen@users.noreply.github.com> Co-authored-by: Mayisha <33387139+Mayisha@users.noreply.github.com> Co-authored-by: Wesley Rosa <wesleyjrosa@gmail.com> Co-authored-by: Rafael Zaleski <rafaelzaleski@users.noreply.github.com> Co-authored-by: Diego Curbelo <diego@curbelo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Fixing some lint issues raised by the WordPress code standards. Ideally these would be enforced in a pre-commit hook, but existing issues need to be fixed first.
Some notes:
wc_cleanis justsanitize_text_fieldwhen applied to a string, but is not detected as a sanitizing function by the linter. It is possible for the values in$_POSTto be something other than a string (TIL), but internallysanitize_text_fieldassumes it's been passed a string (not enforced). For errors about unsanitized input that look likeI've replaced this with
Testing instructions
I think reading the code and making sure unit tests pass is good enough; this should change any behavior.
changelog.txtandreadme.txt(or does not apply)Post merge