This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Remove setFullAddressPushed
to prevent address continually pushing
#9606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
type: bug
The issue/PR concerns a confirmed bug.
focus: blocks
Specific work involving or impacting how blocks behave.
block: checkout
Issues related to the checkout block.
labels
May 26, 2023
woocommercebot
requested review from
a team and
tarunvijwani
and removed request for
a team
May 26, 2023 09:12
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: -226 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
tarunvijwani
requested review from
a team and
mikejolley
and removed request for
tarunvijwani and
a team
May 26, 2023 14:14
7 tasks
mikejolley
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't even remember when fullShippingAddressPushed was added :D Tests as instructed and fixes the refresh issue 👍🏻
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
May 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: checkout
Issues related to the checkout block.
focus: blocks
Specific work involving or impacting how blocks behave.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the actions, selectors, and reducer case for
setFullAddressPushed
from thewc/store/cart
data store.This is no longer used by anything and should have been removed in #8964
Removing this fixes #9591. The reason it fixes it is because we subscribe to changes in the data store in
woocommerce-blocks/assets/js/data/cart/index.ts
Line 35 in 981affa
Due to this, every time the
wc/store/cart
data store changes in any way, thepushChanges
function runs. This is responsible for sending the client-side address to the server.The
pushChanges
function diffs the address in the data store, and the address in the form, and if they are different it sends it to the server.In #9591 we illustrate a case where the address does not push to the server due to an incorrect ZIP code when changing country. Because of this, when the server returns the cart following a push attempt, the old address is there (it doesn't update on the server because it's invalid). Because of this, the push-changes code notices the diff, and tries to re-push.
Because the ZIP code is never revalidated on the client, nothing stops push-changes from running.
Testing
Automated Tests
User Facing Testing
L1 0BP
as the Postcode. Wait for shipping rates to load.Internal testing
Repeat steps above, but use the network monitor in dev tools to watch for batch requests, you should not see continually repeated batch requests.
WooCommerce Visibility
Changelog